RXR-3049: small bug when interval = infusion length#135
Merged
jasmineirx merged 5 commits intomasterfrom Mar 27, 2026
Merged
Conversation
mccarthy-m-g
approved these changes
Mar 25, 2026
Contributor
mccarthy-m-g
left a comment
mccarthy-m-g
left a comment
There was a problem hiding this comment.
lgtm! Just a couple tidy-up suggestions:
Contributor
Author
|
Wrote a better test and found another bug for when t_inf = interval, so re-requested review |
mccarthy-m-g
approved these changes
Mar 26, 2026
Contributor
mccarthy-m-g
left a comment
mccarthy-m-g
left a comment
There was a problem hiding this comment.
New changes look good! Hopefully you don't find a third bug... Just a small grammar suggestion for a code comment that took me a bit to understand.
Do you need to check f-tests before merging?
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where we tried to assign values to a row of length 0, in some cases (interval = infusion length); also removes mockery from tests (deprecated package)