Skip to content

Conversation

@blowekamp
Copy link
Member

These updates in remote modules consisted of incorrect or incomplete dependency specification in tests.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

These updates in remote modules consisted of incorrect or incomplete
dependency specification in tests.
@github-actions github-actions bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances area:Remotes Issues affecting the Remote module labels Jan 30, 2026
@hjmjohnson
Copy link
Member

@dzenanz I am wondering if we should add

            - 'Modules/Remote/*.remote.cmake'

to the github workflows .yml files:

 paths-ignore:
            - '*.md'
            - LICENSE
            - NOTICE
            - 'Documentation/**'
            - 'Utilities/Debugger/**'
            - 'Utilities/ITKv5Preparation/**'
            - 'Utilities/Maintenance/**'

I don't think that remote modules are tested in the github CI, so it is probably not beneficial to use all those resources on these changes.

@dzenanz
Copy link
Member

dzenanz commented Jan 30, 2026

I thought that something was detecting which remote modules were changed and turned them on during the build. But I might be wrong. @thewtex do you remember?

@dzenanz dzenanz merged commit 984acfb into InsightSoftwareConsortium:main Jan 30, 2026
17 checks passed
@thewtex
Copy link
Member

thewtex commented Jan 30, 2026

@hjmjohnson @dzenanz yes, I agree with added those paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Remotes Issues affecting the Remote module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants