Skip to content

STYLE: Remove redundant typename in type aliases#5804

Merged
hjmjohnson merged 1 commit intomainfrom
remove-redundant-typename
Feb 16, 2026
Merged

STYLE: Remove redundant typename in type aliases#5804
hjmjohnson merged 1 commit intomainfrom
remove-redundant-typename

Conversation

@hjmjohnson
Copy link
Member

@hjmjohnson hjmjohnson commented Feb 14, 2026 •
edited
Loading

Refactor code to remove redundant typename specifiers in type aliases
where unnecessary. Simplifies type definitions for improved readability
and consistency while adhering to modern C++ practices.

'typename; is redundant before non-dependent names as of c++17

PR Checklist

@github-actions github-actions bot added area:Examples Demonstration of the use of classes type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module area:ThirdParty Issues affecting the ThirdParty module area:Video Issues affecting the Video module type:Style Style changes: no logic impact (indentation, comments, naming) area:Numerics Issues affecting the Numerics module labels Feb 14, 2026
@hjmjohnson
Copy link
Member Author

hjmjohnson commented Feb 15, 2026

/azp run ITK.macOS.Python

@hjmjohnson hjmjohnson force-pushed the remove-redundant-typename branch from 84d9858 to 4708bb7 Compare February 15, 2026 14:37
@hjmjohnson
STYLE: Remove redundant typename in type aliases
ad0eaca 
Refactor code to remove redundant `typename` specifiers in type aliases
where unnecessary. Simplifies type definitions for improved readability
and consistency while adhering to modern C++ practices.

'typename; is redundant before non-dependent names as of c++17
@hjmjohnson hjmjohnson force-pushed the remove-redundant-typename branch from 4708bb7 to ad0eaca Compare February 15, 2026 17:22
@github-actions github-actions bot removed area:Examples Demonstration of the use of classes type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module area:ThirdParty Issues affecting the ThirdParty module area:Video Issues affecting the Video module area:Numerics Issues affecting the Numerics module labels Feb 15, 2026
@hjmjohnson hjmjohnson requested a review from Copilot February 15, 2026 18:52
Copilot AI reviewed Feb 15, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@hjmjohnson hjmjohnson marked this pull request as ready for review February 15, 2026 21:12
@dzenanz
Copy link
Member

dzenanz commented Feb 16, 2026

/azp run ITK.Windows

dzenanz
dzenanz approved these changes Feb 16, 2026
View reviewed changes
@hjmjohnson
Copy link
Member Author

hjmjohnson commented Feb 16, 2026

Failing cdash test is un-related to this PR. It is an unstable test on windows.

@hjmjohnson hjmjohnson merged commit 9664c69 into main Feb 16, 2026
18 of 21 checks passed
@hjmjohnson hjmjohnson deleted the remove-redundant-typename branch February 16, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@dzenanz dzenanz dzenanz approved these changes

Assignees

No one assigned

Labels

type:Style Style changes: no logic impact (indentation, comments, naming)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hjmjohnson @dzenanz