STYLE: Replace T v = T(a, b) variable declarations with T v(a, b)#5830
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:mainfrom Feb 25, 2026
Conversation
github-actions
Bot
added
area:Filtering
dzenanz
approved these changes
Feb 24, 2026
hjmjohnson
approved these changes
Feb 24, 2026
N-Dekker
force-pushed
the
Avoid-same-type-name-twice-in-variable-declaration
branch
from
dd676b5 to
30a1965
Compare
Contributor
Author
|
Last minute force-push, including types that are instantiated template classes 😺 |
dzenanz
approved these changes
Feb 25, 2026
N-Dekker
force-pushed
the
Avoid-same-type-name-twice-in-variable-declaration
branch
from
30a1965 to
d3a5c5f
Compare
Using Notepad++, Replace in Files, doing
Find what: ` (\w+)([ ]+\w+) = \1(\(.+\);)`
Replace with: ` $1$2$3`
Find what: ` (\w+<.*>)([ ]+\w+) = \1(\(.+\);)`
Replace with: ` $1$2$3`
Find what: ` (\w+<\w+>)([ ]+\w+) =\r\n[ ]+\1(\()`
Replace with: ` $1$2$3`
[v] Match case
(*) Regular expression
Aims to avoid having the very same type name twice in a single variable
declaration, following the "DRY principle" ("Don't Repeat Yourself") .
Contributor
Author
|
Included variable declarations that have a line break, with this force-push! |
N-Dekker
force-pushed
the
Avoid-same-type-name-twice-in-variable-declaration
branch
from
d3a5c5f to
45d4afd
Compare
thewtex
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
(\w+)([ ]+\w+) = \1(\(.+\);)with$1$2$3initk*.hxxfiles, using regular expressions.Aims to avoid having the very same type name twice in a single variable declaration, following the "DRY principle".