STYLE: remove redundant control fllow#5835
Merged
hjmjohnson merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
dzenanz
approved these changes
Feb 25, 2026
N-Dekker
approved these changes
Feb 25, 2026
Contributor
N-Dekker
left a comment
There was a problem hiding this comment.
Thanks Hans!
Just a nitpick: the subject of the commit message, "STYLE: remove redundant control fllow" has a redundant letter l in "fllow". The commit text suggests that continue might also be removed, but that's not the case. The commit only removes return statements. So I would prefer a commit subject line like:
STYLE: Remove redundant `return;` statements
Just a suggestion, not a show-stopper.
thewtex
approved these changes
Feb 26, 2026
The clang-tidy check readability-redundant-control-flow looks for procedures (functions returning no value) with return statements at the end of the function. Such return statements are redundant.
b17a363 to
18d4d48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clang-tidy check readability-redundant-control-flow looks for procedures
(functions returning no value) with return statements at the end of the
function. Such return statements are redundant.
Loop statements (for, while, do while) are checked for redundant continue
statements at the end of the loop body.
PR Checklist