COMP: Let NthElementPixelAccessor follow the Rule of Zero#5849
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:mainfrom Mar 3, 2026
Merged
Conversation
Removed its user-declared defaulted default-constructor and assignment operator,
in order to address C++20 warnings, saying (on Linux/GCC 11.4.0):
warning: implicitly-declared 'constexpr NthElementPixelAccessor::NthElementPixelAccessor(const NthElementPixelAccessor&)' is deprecated [-Wdeprecated-copy]
github-actions
Bot
added
type:Compiler
dzenanz
approved these changes
Mar 2, 2026
hjmjohnson
approved these changes
Mar 3, 2026
N-Dekker
commented
Mar 3, 2026
Comment on lines
-105
to
-106
| NthElementPixelAccessor & | ||
| operator=(const NthElementPixelAccessor & accessor) = default; |
Contributor
Author
There was a problem hiding this comment.
Even though I think the warning is helpful, I don't think the note that GCC added is entirely correct. It says:
note: because 'itk::NthElementPixelAccessor' has user-provided 'itk::NthElementPixelAccessor& itk::NthElementPixelAccessor::operator=(const itk::NthElementPixelAccessor&)
However, this operator= is only user-declared, it is not "user-provided"! 🤓
dzenanz
merged commit 4fcd284
into
InsightSoftwareConsortium:main
17 of 18 checks passed
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Mar 9, 2026
Let the assignment operator be implicitly defaulted (compiler generated), for the
VariableLengthVector specific template specialization of NthElementPixelAccessor.
Aims to address warnings appearing on Linux/GCC 11.4.0 saying:
warning: implicitly-declared 'constexpr NthElementPixelAccessor::NthElementPixelAccessor(const NthElementPixelAccessor&)' is deprecated [-Wdeprecated-copy]
Follow-up to pull request InsightSoftwareConsortium#5849
commit 00ead18
"COMP: Let NthElementPixelAccessor follow the Rule of Zero"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed its user-declared defaulted default-constructor and assignment operator, in order to address C++20 warnings, saying (on Linux/GCC 11.4.0):
The warning can be found at https://open.cdash.org/builds/11081768/errors
Full text: