STYLE: Remove redundant virtual statements for C++11#5908
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:mainfrom Mar 9, 2026
Merged
Conversation
github-actions
bot
added
area:Segmentation
N-Dekker
reviewed
Mar 8, 2026
hjmjohnson
changed the title
Use virtual for the base class function declaration. This is technically necessary.
hjmjohnson
force-pushed
the
clang-tidy-rules-testing
branch
from
6b0263f to
9ee0b6b
Compare
N-Dekker
approved these changes
Mar 9, 2026
Contributor
N-Dekker
left a comment
N-Dekker
left a comment
There was a problem hiding this comment.
Thanks @hjmjohnson !
I still like my suggestion STYLE: Remove redundant virtual keywords from overrides, because it is more specific. But your STYLE: Remove redundant virtual keyword is good enough 👍
Member
Author
|
/azp run ITK.macOS.Python |
hjmjohnson
merged commit 4169ee5
into
InsightSoftwareConsortium:main
14 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use virtual for the base class function declaration. This is technically
necessary.
Remove 'virtual' is implied when 'override' is specified, so remove the
redundant specification.
cd ${BLDDIR}
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-,modernize-use-override -header-filter=. -fix
PR Checklist