Revert "BUG: Use std::forward instead of std::move on forwarding references"#5963
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:mainfrom Mar 17, 2026
Merged
Conversation
github-actions
bot
added
type:Infrastructure
Contributor
|
Thanks, Hans. Please note that the commit message is incorrect, as it says:
Instead, these tests are just testing move-semantics! |
…rences" This reverts commit 14c265b. The tests are testing move-semantics.
hjmjohnson
force-pushed
the
revert-forward-move
branch
from
3059fc5 to
a7c99c7
Compare
hjmjohnson
merged commit 2a1ebd4
into
InsightSoftwareConsortium:main
17 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 14c265b.
The tests are just testing move-semantics
PR Checklist