STYLE: Replace Allocate(true) with AllocateInitialized()

[hjmjohnson]

Summary

Replaces all ->Allocate(true) call sites with the self-documenting alias ->AllocateInitialized() throughout Modules/ and Examples/.

Motivation

Allocate(true) zero-initializes the image buffer, but the boolean argument is easy to misread. AllocateInitialized() was added to itkImageBase.h specifically for readability:

"AllocateInitialized() is equivalent to Allocate(true). It is just intended to make the code more readable."

The redundant trailing comments (// initialize buffer to zero) are also removed since the method name is now self-documenting.

Scope

• Modules/IO/TransformMINC/src/itkMINCTransformIO.cxx — 2 sites
• Examples/ — 6 sites

Allocate() (no args) and Allocate(false) are not changed. The definition in itkImageBase.h is unchanged.

Pure mechanical substitution — no semantic change.

Suggested by @N-Dekker in #6003 (comment)

[greptile-apps]

Greptile Summary

This PR performs a purely mechanical, style-only substitution across 7 files, replacing Allocate(true) with the self-documenting alias AllocateInitialized(), which is defined in itkImageBase.h as an inline wrapper (return this->Allocate(true)) — semantically identical with zero behavioral change. Redundant inline comments such as // initialize buffer to zero are also removed since the method name now conveys the intent directly.

• Examples/DataRepresentation/Image/Image3.cxx — image->Allocate(true) → image->AllocateInitialized(), comment removed
• Examples/DataRepresentation/Image/Image4.cxx — same substitution and comment removal
• Examples/Filtering/DigitallyReconstructedRadiograph1.cxx — same substitution, // initialize to zero. comment removed
• Examples/Segmentation/HoughTransform2DCirclesImageFilter.cxx — same substitution, // initializes buffer to zero comment removed
• Examples/Segmentation/HoughTransform2DLinesImageFilter.cxx — same substitution and comment removal
• Examples/SpatialObjects/ImageMaskSpatialObject.cxx — same substitution and comment removal
• Modules/IO/TransformMINC/src/itkMINCTransformIO.cxx — two replacements in ReadOneTransform and WriteOneTransform; no comments were present at these sites

Confidence Score: 5/5

This PR is safe to merge — it is a pure style substitution with no behavioral change.

AllocateInitialized() is confirmed in itkImageBase.h as an inline alias for Allocate(true). All 8 call sites are mechanically identical replacements. No logic, data flow, or API contracts are affected.

No files require special attention — all changes are trivially correct.

Important Files Changed

Filename	Overview
Examples/DataRepresentation/Image/Image3.cxx	Replaced image->Allocate(true); // initialize buffer to zero with image->AllocateInitialized() — mechanical style substitution, no semantic change
Examples/DataRepresentation/Image/Image4.cxx	Replaced image->Allocate(true); // initialize buffer to zero with image->AllocateInitialized() — same style substitution as Image3.cxx
Examples/Filtering/DigitallyReconstructedRadiograph1.cxx	Replaced image->Allocate(true); // initialize to zero. with image->AllocateInitialized(), removing the now-redundant comment
Examples/Segmentation/HoughTransform2DCirclesImageFilter.cxx	Replaced localOutputImage->Allocate(true); // initializes buffer to zero with localOutputImage->AllocateInitialized()
Examples/Segmentation/HoughTransform2DLinesImageFilter.cxx	Replaced localOutputImage->Allocate(true); // initialize buffer to zero with localOutputImage->AllocateInitialized()
Examples/SpatialObjects/ImageMaskSpatialObject.cxx	Replaced image->Allocate(true); // initialize buffer to zero with image->AllocateInitialized(), removing the now-redundant comment
Modules/IO/TransformMINC/src/itkMINCTransformIO.cxx	Two replacements of ->Allocate(true) with ->AllocateInitialized() in ReadOneTransform and WriteOneTransform; no comments were present

Sequence Diagram

sequenceDiagram
    participant Caller
    participant Image as ITK Image
    participant Buffer as Pixel Buffer

    Note over Caller,Image: Before PR
    Caller->>Image: Allocate(true)
    Image->>Buffer: allocate + zero-initialize
    Buffer-->>Caller: done

    Note over Caller,Image: After PR (semantically identical)
    Caller->>Image: AllocateInitialized()
    Image->>Image: Allocate(true)  [inline alias in itkImageBase.h]
    Image->>Buffer: allocate + zero-initialize
    Buffer-->>Caller: done

Loading

_{Reviews (2): Last reviewed commit: "STYLE: Replace Allocate(true) with Alloc..." | Re-trigger Greptile}

[N-Dekker]

• Nice follow-up to Add and use itk::ImageBase::AllocateInitialized() #4479 (commit 527843e)! Apparently I had forgotten the Examples, when I made that PR! My bad!

Did you test it locally? You know, the CI doesn't build the Examples!

Do you think Claude specifically uses the examples for its code generation?

[hjmjohnson]

Local Build & Test Report (macOS arm64, clang++)

Platform: macOS 15.1, Apple Silicon (arm64)
Compiler: /usr/bin/clang++ (Xcode), C++17, Release
Build options: BUILD_EXAMPLES=ON, BUILD_TESTING=ON, Module_ITKIOTransformMINC=ON
Source: branch style-allocate-initialized @ 038880c6a1

Build: ✅ No errors or warnings

All 7 changed targets compiled and linked cleanly:

Target	File
Image3	Examples/DataRepresentation/Image/Image3.cxx
Image4	Examples/DataRepresentation/Image/Image4.cxx
DigitallyReconstructedRadiograph1	Examples/Filtering/DigitallyReconstructedRadiograph1.cxx
HoughTransform2DCirclesImageFilter	Examples/Segmentation/HoughTransform2DCirclesImageFilter.cxx
HoughTransform2DLinesImageFilter	Examples/Segmentation/HoughTransform2DLinesImageFilter.cxx
ImageMaskSpatialObject	Examples/SpatialObjects/ImageMaskSpatialObject.cxx
ITKIOTransformMINC	Modules/IO/TransformMINC/src/itkMINCTransformIO.cxx

Tests: ✅ 28/28 passed

100% tests passed, 0 tests failed out of 28

Label Time Summary:
ITKIOMINC              =   0.79 sec (2 tests)
ITKIOTransformMINC     =   0.61 sec (2 tests)
ITKImageFeature        =   1.24 sec (2 tests)  [HoughTransform]
ITKSpatialObjects      =   1.19 sec (5 tests)  [ImageMaskSpatialObject]
ITKFFTImageFilterInit  =   5.18 sec (6 tests)  [DigitallyReconstructedRadiograph1]

No regressions detected. The ->AllocateInitialized() substitution is purely mechanical with no behavioral change.

[hjmjohnson]

Pixi-Cxx CI failure note: The Pixi-Cxx (ubuntu-22.04) failure is not caused by this PR. Build succeeded; the Test step was cancelled (null conclusion). The same ITK.Pixi workflow was also failing on main at commit b94cca51 with a different platform failing — this is pre-existing infrastructure flakiness. All other CI checks (Windows, macOS, ARM64) pass.

[N-Dekker]

Thanks, Hans!