ENH: Ingest ITKLabelErodeDilate into Modules/Filtering#6171
Merged
hjmjohnson merged 141 commits intoInsightSoftwareConsortium:mainfrom Apr 30, 2026
Merged
ENH: Ingest ITKLabelErodeDilate into Modules/Filtering#6171hjmjohnson merged 141 commits intoInsightSoftwareConsortium:mainfrom
hjmjohnson merged 141 commits intoInsightSoftwareConsortium:mainfrom
Conversation
ITK3 support
Use medial capitals for variable naming in C++ code. Avoid underscores.
…ormToITKLocalVbleNamingStyle STYLE: Conform to ITK local variable naming style
…oveTestsStyle STYLE: Miscellaneous style improvements to tests
Co-author: Jon Haitz Legarreta Gorroño <jon.haitz.legarreta@gmail.com>
…lgrind_uninitialized BUG: Fix Valgrind defect with uninitialized array in doOneDimensionErode
Initialize all arrays in `LabelSetUtils.h` file.
…ializeAllArrays ENH: Initialize all arrays in `LabelSetUtils.h` file
…acro Added two new macro's, intended to replace the old 'itkTypeMacro' and 'itkTypeMacroNoParent'. The main aim is to be clearer about what those macro's do: add a virtual 'GetNameOfClass()' member function and override it. Unlike 'itkTypeMacro', 'itkOverrideGetNameOfClassMacro' does not have a 'superclass' parameter, as it was not used anyway. Note that originally 'itkTypeMacro' did not use its 'superclass' parameter either, looking at commit 699b66c, Will Schroeder, June 27, 2001: https://github.com/InsightSoftwareConsortium/ITK/blob/699b66cb04d410e555656828e8892107add38ccb/Code/Common/itkMacro.h#L331-L337
Remove unused variable.
Fixes:
```
Modules/Remote/LabelErodeDilate/include/itkLabelSetUtils.h:260:37:
warning: unused variable 'initPixelValue' [-Wunused-variable]
260 | const typename TInIter::PixelType initPixelValue = 0.0;
| ^~~~~~~~~~~~~~
```
raised for example in:
https://open.cdash.org/viewBuildError.php?type=1&buildid=10316578
Introducing the variable was an oversight in commit 82097b4.
…nusedVariableWarning COMP: Remove unused variable
Following ITK pull request InsightSoftwareConsortium#5692 "Deprecate `MultiThreaderType` aliases, use `MultiThreaderBase` directly"
Migrate ExternalData tag files to CIDv1-raw form. The CID blobs are added to ITKTestingData gh-pages in InsightSoftwareConsortium/ITKTestingData#43.
Brings LabelErodeDilate from a configure-time remote fetch into the ITK source tree at Modules/Filtering/LabelErodeDilate/ using the v3 whitelist filter-repo pipeline. Upstream repo: https://github.com/InsightSoftwareConsortium/ITKLabelErodeDilate.git Upstream tip: 535848354f8a58cde85dee0fef76619ce7eed38e Ingest date: 2026-04-29 Whitelist passes (git filter-repo): - --path include --path src --path test --path wrapping - --path CMakeLists.txt --path itk-module.cmake - --to-subdirectory-filter Modules/Filtering/LabelErodeDilate - --prune-empty always - (if present) second pass: invert CTestConfig.cmake Outcome: 202 upstream commits -> 138 surviving; 18 distinct authors preserved; git blame walks across the merge boundary to original authors. Content-link inventory: .md5=0 .shaNNN=0 .cid=18 Primary author: Richard Beare <richard.beare@monash.edu> Co-authored-by: Bradley Lowekamp <blowekamp@mail.nih.gov> Co-authored-by: Dženan Zukić <dzenan.zukic@kitware.com> Co-authored-by: Francois Budin <francois.budin@kitware.com> Co-authored-by: Hans J. Johnson <hans-johnson@uiowa.edu> Co-authored-by: Hans Johnson <hans-johnson@uiowa.edu> Co-authored-by: Jerome Avondo <jeromeavondo@msn.com> Co-authored-by: Jon Haitz Legarreta <jhlegarreta@vicomtech.org> Co-authored-by: Jon Haitz Legarreta Gorroño <jhlegarreta@vicomtech.org> Co-authored-by: Jon Haitz Legarreta Gorroño <jon.haitz.legarreta@gmail.com> Co-authored-by: Mathew J. Seng <mathewseng@gmail.com> Co-authored-by: Mathew Seng <mathewseng@gmail.com> Co-authored-by: Matt McCormick <matt.mccormick@kitware.com> Co-authored-by: Matt McCormick <matt@mmmccormick.com> Co-authored-by: Niels Dekker <N.Dekker@lumc.nl> Co-authored-by: Richard Beare <Richard.Beare@gmail.com> Co-authored-by: Richard Beare <Richard.Beare@ieee.org> Co-authored-by: Tom Birdsong <tom.birdsong@kitware.com>
Add Modules/Filtering/LabelErodeDilate/README.md documenting the ingested module and pointing at the upstream archive, remove Modules/Remote/LabelErodeDilate.remote.cmake, and add -DModule_LabelErodeDilate:BOOL=ON to the pyproject.toml configure-ci task so the in-tree module is exercised on every CI run.
github-actions
Bot
added
type:Infrastructure
dzenanz
approved these changes
Apr 30, 2026
Member
|
Commit prefixes and whitespaces seem to not have been applied, the rest looks good. Acceptable even as-is. |
hjmjohnson
merged commit 690015c
into
InsightSoftwareConsortium:main
16 of 17 checks passed
50 tasks
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…est-LabelErodeDilate ENH: Ingest ITKLabelErodeDilate into Modules/Filtering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ingest the ITKLabelErodeDilate remote module into
Modules/Filtering/LabelErodeDilate/, preserving upstreamgit blamevia a--no-fffilter-repo merge per INGESTION_STRATEGY.md. Tracked under master issue #6160 (Wave 1).Validation gates (all passed locally)
upstream/main..HEAD)verify-cid-access.sh(18 .cid content links)pre-commit run --all-filespost-autosquashpixi run -e cxx configure-ciLabelErodeDilate-all(3402 targets)itkLabel(Dilate|Erode)Test*Commit topology
Off
upstream/main(b10b293775):--rebase-mergesautosquash)ENH: Ingest ITKLabelErodeDilate into Modules/Filtering— 2-parent mergeDOC: Add README for in-tree LabelErodeDilate; drop remote fetch— addsModules/Filtering/LabelErodeDilate/README.md, removesModules/Remote/LabelErodeDilate.remote.cmake, adds-DModule_LabelErodeDilate:BOOL=ONto pyproject.toml configure-ciSTYLE: Apply gersemi + trim trailing whitespace to LabelErodeDilate— also replaces upstream'sfile(READ README.rst)(which was a dangling reference — README.rst never existed upstream) with inlineset(DOCUMENTATION ...)matching the MeshNoise/FastBilateral patternPost-merge follow-ups
MIGRATION_README.md, mark repo Archived.