COMP: Move CMake's include(ITKWindowsUtf8) for external modules

[SimonRit]

The inclusion in the root CMakeLists.txt was causing the following configure error when compiling a module externally:

CMake Error at C:/src/itk/ITK-main/CMake/ITKModuleTest.cmake:93 (itk_target_attach_windows_utf8_manifest):
  Unknown CMake command "itk_target_attach_windows_utf8_manifest".
Call Stack (most recent call first):
  test/CMakeLists.txt:22 (createtestdriver)

See e.g. https://my.cdash.org/builds/3530626/configure.

PR Checklist

• No API changes were made (or the changes have been approved)
• No major design changes were made (or the changes have been approved)
• Added test (or behavior not changed)
• Updated API documentation (or API not changed)
• Added license to new files (if any)
• Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
• Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

[SimonRit]

Caused by #6209 @hjmjohnson.

[greptile-apps]

Greptile Summary

This PR fixes a configure-time error for external ITK modules on Windows by moving include(ITKWindowsUtf8) from the root CMakeLists.txt into CMake/ITKModuleTest.cmake, where the itk_target_attach_windows_utf8_manifest function it defines is actually consumed.

• CMakeLists.txt: Removes the top-level include(ITKWindowsUtf8) that was previously defined before include(ITKModuleTest).
• CMake/ITKModuleTest.cmake: Adds include(ITKWindowsUtf8) at the top of the file so the itk_target_attach_windows_utf8_manifest command is always available whenever this module is included, including from external module builds that never process the root CMakeLists.txt.

Confidence Score: 5/5

Safe to merge; the change is minimal and correctly targets the root cause of the Windows external-module configure failure.

Moving the include into ITKModuleTest.cmake ensures itk_target_attach_windows_utf8_manifest is always defined when it is called, both for in-tree builds and external module builds. The only other direct caller, Modules/Core/TestKernel/src/CMakeLists.txt, is always processed after the root include chain, so it continues to work. ITKWindowsUtf8.cmake uses CMAKE_CURRENT_LIST_DIR internally, which always resolves to its own directory regardless of who includes it, so the manifest path remains correct.

No files require special attention.

Important Files Changed

Filename	Overview
CMakeLists.txt	Removes the now-redundant top-level include(ITKWindowsUtf8); the include is now co-located with its user in ITKModuleTest.cmake and will still be processed before any module source CMakeLists.txt in both in-tree and external builds.
CMake/ITKModuleTest.cmake	Adds include(ITKWindowsUtf8) at file scope so itk_target_attach_windows_utf8_manifest is always defined when CreateTestDriver or CreateGoogleTestDriver call it, fixing the Unknown CMake command error for external module builds.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Root CMakeLists.txt] -->|include| B[ITKModuleMacros]
    A -->|include| C[ITKExternalData]
    A -->|include| D[ITKModuleTest.cmake]
    D -->|include| E[ITKWindowsUtf8.cmake]
    E -->|defines| F[itk_target_attach_windows_utf8_manifest]
    D -->|defines| G[CreateTestDriver]
    D -->|defines| H[CreateGoogleTestDriver]
    G -->|calls| F
    H -->|calls| F
    I[External Module Build] -->|include| D
    J[Modules/Core/TestKernel/src/CMakeLists.txt] -->|calls directly| F
    style E fill:#90EE90
    style F fill:#90EE90

Loading

_{Reviews (1): Last reviewed commit: "COMP: Move CMake's include(ITKWindowsUtf..." | Re-trigger Greptile}

[hjmjohnson]

Thank you @SimonRit