ENH: Ingest ITKSimpleITKFilters into Modules/Filtering/SimpleITKFilters

[hjmjohnson]

Ingest the ITKSimpleITKFilters remote module into Modules/Filtering/SimpleITKFilters (group: Filtering). Source upstream: SimpleITK/ITKSimpleITKFilters. Tracking issue: #6160.

Ingest stats

• Commits: 79 (including 13 merge commits -- Mode A topology preserved per Utilities/Maintenance/RemoteModuleIngest/INGESTION_STRATEGY.md)
• Files installed under Modules/Filtering/SimpleITKFilters/: 33
• Approx. content size: 128 KiB
• Tip SHA: c1f18fdde73398a4e038f2b2035c0f9738f964bf

External-data fixtures

CID / .sha512 content-links present in this ingest:

• Modules/Filtering/SimpleITKFilters/test/Baseline/ObjectnessMeasureImageFilterTest1.nii.cid
• Modules/Filtering/SimpleITKFilters/test/Baseline/ObjectnessMeasureImageFilterTest2.nii.cid
• Modules/Filtering/SimpleITKFilters/test/Baseline/itkHessianToObjectnessMeasureImageFilterTest2.mha.cid
• Modules/Filtering/SimpleITKFilters/test/Input/DSA.png.cid
• Modules/Filtering/SimpleITKFilters/test/Input/itkHessianToObjectnessMeasureImageFilterTest.mha.cid

If any fixtures resolve via ITKTestingData, that repo must contain the matching content-link before this PR can merge cleanly.

Follow-on commits (on top of the unrelated-histories merge)

• c1f18fd ENH: Enable Module_SimpleITKFilters and remove remote stub
• f4118d7 ENH: Convert from md5 to .cid tags.
• 410f9c3 ENH: ITKv5_CONST macro for VerifyPreconditions() and VerifyInputInformation()
• f3d3d1f COMP: Use modern macro for name of class
• 33fadfb ENH: Wrap DICOMOrientation

[hjmjohnson]

@greptileai review this draft before I make it official

[hjmjohnson]

@greptileai review this draft before I make it official

[greptile-apps]

Greptile Summary

This PR ingests the ITKSimpleITKFilters remote module into Modules/Filtering/SimpleITKFilters, replacing the remote stub (Modules/Remote/SimpleITKFilters.remote.cmake) with the full in-tree source. Five filters are brought in: DICOMOrientImageFilter, DICOMOrientation, HessianImageFilter, MaskedAssignImageFilter, NPasteImageFilter, and ObjectnessMeasureImageFilter, along with tests, Python wrapping stubs, and CI enablement in pyproject.toml.

• The remote cmake stub is correctly deleted and Module_SimpleITKFilters is enabled in CI via pyproject.toml.
• itkNPasteImageFilterGTest.cxx is added to the repo but omitted from the SimpleITKFiltersGTest CMake source list, so its tests are never compiled or run.
• The #ifndef ITK_MANUAL_INSTANTIATION / #include \".hxx\" block in itkMaskedAssignImageFilter.h is placed after the closing #endif of the header include guard, contrary to the pattern used in all other filters in this module.

Confidence Score: 3/5

The module ingest is broadly correct, but the NPaste GTests are silently excluded from the build, meaning a whole filter's test suite goes unexercised on CI.

The NPasteImageFilter GTest file exists in the repo but is absent from the CMake driver list — every test in that file is dead on CI. The include-guard misplacement in itkMaskedAssignImageFilter.h is a style deviation with no runtime impact. Together these reduce confidence that the module is fully exercised.

Modules/Filtering/SimpleITKFilters/test/CMakeLists.txt (missing NPaste GTest source) and Modules/Filtering/SimpleITKFilters/include/itkMaskedAssignImageFilter.h (include guard ordering).

Important Files Changed

Filename	Overview
Modules/Filtering/SimpleITKFilters/test/CMakeLists.txt	itkNPasteImageFilterGTest.cxx is present in the repo but missing from the SimpleITKFiltersGTest list, so the NPaste GTests are never compiled or run.
Modules/Filtering/SimpleITKFilters/itk-module.cmake	Module declared with ITKCommon and ITKImageFeature dependencies; ITKImageGrid (used by DICOMOrientImageFilter) is missing from DEPENDS.
Modules/Filtering/SimpleITKFilters/include/itkMaskedAssignImageFilter.h	Header include guard is correct but the #ifndef ITK_MANUAL_INSTANTIATION block is placed after the guard's closing #endif, contrary to the pattern in every other filter in this module.
Modules/Filtering/SimpleITKFilters/include/itkDICOMOrientImageFilter.h	Well-structured 3-D orientation filter wrapping PermuteAxes + Flip; static_assert enforces 3-D restriction.
Modules/Filtering/SimpleITKFilters/include/itkDICOMOrientImageFilter.hxx	Mini-pipeline implementation using PermuteAxes + Flip + Cast; orientation determination logic looks correct.
Modules/Filtering/SimpleITKFilters/include/itkNPasteImageFilter.h	Multi-dimensional paste filter; static_assert guards dimension constraint; include guard pattern is correct.
Modules/Filtering/SimpleITKFilters/include/itkObjectnessMeasureImageFilter.h	Composite filter wrapping HessianImageFilter + HessianToObjectnessMeasureImageFilter; parameters and destructor look correct.
Modules/Filtering/SimpleITKFilters/src/itkDICOMOrientation.cxx	Static map initialization for orientation code ↔ string conversion is complete and correct; orientation math looks sound.
Modules/Remote/SimpleITKFilters.remote.cmake	Remote stub correctly removed as part of the ingest; no residual references expected.
pyproject.toml	CI configuration correctly enables Module_SimpleITKFilters for the configure-ci step.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Input Image] --> B[DICOMOrientImageFilter]
    B --> C{NeedToPermute?}
    C -- Yes --> D[PermuteAxesImageFilter]
    C -- No --> E[skip permute]
    D --> F{NeedToFlip?}
    E --> F
    F -- Yes --> G[FlipImageFilter]
    F -- No --> H[skip flip]
    G --> I[CastImageFilter]
    H --> I
    I --> J[Output Image]

    K[Input Image] --> L[ObjectnessMeasureImageFilter]
    L --> M[HessianImageFilter]
    M --> N[HessianToObjectnessMeasureImageFilter]
    N --> O[Objectness Output]

    P[DestinationImage] --> Q[NPasteImageFilter]
    R[SourceImage / Constant] --> Q
    Q --> S[Pasted Output]

    T[InputImage] --> U[MaskedAssignImageFilter]
    V[MaskImage] --> U
    W[AssignImage / Constant] --> U
    U --> X[Masked Output]

Loading

_{Reviews (1): Last reviewed commit: "ENH: Enable Module_SimpleITKFilters and ..." | Re-trigger Greptile}

[greptile-apps]

Greptile Summary

Ingests the ITKSimpleITKFilters remote module into Modules/Filtering/SimpleITKFilters, adding five filters (DICOMOrientImageFilter, DICOMOrientation, HessianImageFilter, MaskedAssignImageFilter, NPasteImageFilter, ObjectnessMeasureImageFilter) along with wrapping, tests, and CID-based test data. The remote stub is removed and pyproject.toml is updated to enable the module in CI.

• itkNPasteImageFilterGTest.cxx is added to the repo but omitted from SimpleITKFiltersGTest in test/CMakeLists.txt, so its tests are never compiled or run.
• itk-module.cmake leaves COMPILE_DEPENDS empty despite itkDICOMOrientImageFilter.h including headers from ITKImageGrid (PermuteAxesImageFilter, FlipImageFilter), which could break standalone/external builds.
• Minor quality issues remain: a dead #if 0 block in itkDICOMOrientation.h and two small typos in doc strings and a static assertion message.

Confidence Score: 3/5

Safe to merge after fixing the NPaste test registration; the filter implementations themselves appear correct.

The NPaste Google Test file is shipped but never compiled — the test driver omits it — so the entire NPaste test suite is silently skipped. Merging as-is means NPasteImageFilter goes into the tree with no executed tests, which is the kind of gap that lets regressions slip through undetected. The remaining issues (missing ITKImageGrid in COMPILE_DEPENDS, dead #if 0 block, two small typos) are minor and do not affect runtime behavior.

test/CMakeLists.txt (missing test registration) and itk-module.cmake (empty COMPILE_DEPENDS despite headers from ITKImageGrid)

Important Files Changed

Filename	Overview
Modules/Filtering/SimpleITKFilters/test/CMakeLists.txt	Missing itkNPasteImageFilterGTest.cxx from SimpleITKFiltersGTest — NPaste Google Tests are never compiled or run
Modules/Filtering/SimpleITKFilters/itk-module.cmake	COMPILE_DEPENDS is empty but itkDICOMOrientImageFilter.h includes headers from ITKImageGrid (PermuteAxesImageFilter, FlipImageFilter); external builds may miss include directories
Modules/Filtering/SimpleITKFilters/include/itkDICOMOrientation.h	Introduces DICOMOrientation orientation enum/utility class; contains a dead #if 0 branch and a minor doc typo
Modules/Filtering/SimpleITKFilters/include/itkDICOMOrientImageFilter.h	Adds 3-D-only DICOM orient filter; static_assert message has typo ("are support" → "are supported")
Modules/Filtering/SimpleITKFilters/include/itkDICOMOrientImageFilter.hxx	Template implementation of DICOMOrientImageFilter; logic for permutation/flip determination and mini-pipeline looks correct
Modules/Filtering/SimpleITKFilters/src/itkDICOMOrientation.cxx	Implements orientation enum ↔ string and direction-cosine conversions; operator<< uses assert (no-op in release) but all valid enum values are covered in the map
Modules/Filtering/SimpleITKFilters/include/itkObjectnessMeasureImageFilter.h	Composite wrapper combining HessianImageFilter and HessianToObjectnessMeasureImageFilter; API looks complete and correct
Modules/Filtering/SimpleITKFilters/include/itkNPasteImageFilter.h	Adds N-dimensional paste filter with in-place support and lower-dimensional source images; API looks clean
Modules/Remote/SimpleITKFilters.remote.cmake	Remote module stub correctly removed as part of the ingestion
pyproject.toml	Correctly enables Module_SimpleITKFilters in the CI configure step

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Input Image] --> B[DICOMOrientImageFilter]
    B --> B1[DICOMOrientation\nDirectionCosinesToOrientation]
    B1 --> B2[DeterminePermutationsAndFlips]
    B2 --> B3{NeedToPermute?}
    B3 -- Yes --> C[PermuteAxesImageFilter]
    B3 -- No --> D
    C --> D{NeedToFlip?}
    D -- Yes --> E[FlipImageFilter]
    D -- No --> F
    E --> F[CastImageFilter]
    F --> G[Output Image]

    H[Input Image] --> I[ObjectnessMeasureImageFilter]
    I --> J[HessianImageFilter]
    J --> K[HessianToObjectnessMeasureImageFilter]
    K --> L[Output Objectness Image]

    M[Destination Image] --> N[NPasteImageFilter]
    O[Source Image / Constant] --> N
    N --> P[Output Image with pasted region]

Loading

_{Reviews (2): Last reviewed commit: "ENH: Enable Module_SimpleITKFilters and ..." | Re-trigger Greptile}

[blowekamp]

I thought we agree to not ingest the SimpleITKFilters remote module?

I have not been looking closely at the criteria for the other modules being ingested. There is too many GH messages to follow.

[hjmjohnson]

/azp run

[blowekamp]

STOP WORK PLEASE.

[hjmjohnson]

I removed SimpleITKFilters from the list of Phase3 import and moved it to the "remain remote" phase 4 in issue #6160