BUG: Fix check for orphaned remote modules#6398
Conversation
|
| Filename | Overview |
|---|---|
| CMake/itkCheckForOrphanedRemoteModules.cmake | Adds ITK prefix stripping and an exception list for modules with mismatched directory/cmake names; the scifio-imageio exception is correct, but the ITK-Wasm exception string does not match the stripped name (-Wasm vs ITK-Wasm), a bug flagged in a prior review thread. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Glob all entries in Modules/Remote/*] --> B{Is entry a directory?}
B -- No --> C[Skip]
B -- Yes --> D[get_filename_component: extract _name]
D --> E["string(REGEX REPLACE '^ITK' '' _name)"]
E --> F{"_name == 'Deprecated'\nOR 'ITK-Wasm'\nOR 'scifio-imageio'?"}
F -- Yes --> G[continue / skip]
F -- No --> H{"_remote_dir/_name.remote.cmake\nOR Deprecated/_name.remote.cmake\nexists?"}
H -- Yes --> I[OK - module is not orphaned]
H -- No --> J[Append to _orphans list]
J --> K{Any orphans found?}
I --> K
K -- No --> L[Done - no orphans]
K -- Yes --> M[message FATAL_ERROR with rm commands]
Reviews (2): Last reviewed commit: "BUG: Fix check for orphaned remote modul..." | Re-trigger Greptile
Some remote modules have a repository name which does not match the .remote.cmake file name. A few start with ITK, SCIFIO is named scifio-imageio, WebAssemblyInterface is named ITK-Wasm.
|
@greptileai review |
8b6277d
into
InsightSoftwareConsortium:main
Some remote modules have a repository name which does not match the .remote.cmake file name. A few start with ITK, SCIFIO is named scifio-imageio, WebAssemblyInterface is named ITK-Wasm.
I used the following bash command line in
Modules/Remoteto check the list of exceptions:PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.