ENH: Update compiler macros#810
Merged
hjmjohnson merged 4 commits intoInsightSoftwareConsortium:masterfrom May 7, 2019
maekclena:macro_cleanup
Merged
ENH: Update compiler macros#810hjmjohnson merged 4 commits intoInsightSoftwareConsortium:masterfrom maekclena:macro_cleanup
hjmjohnson merged 4 commits intoInsightSoftwareConsortium:masterfrom
maekclena:macro_cleanup
Conversation
dzenanz
requested changes
May 2, 2019
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
It is good you have taken this up. Some suggestions in-line.
dzenanz
reviewed
May 3, 2019
dzenanz
approved these changes
May 6, 2019
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Fantastic. The only thing left is to get the green dashboard.
Please squash before merging.
Member
|
@maekclena do you have a discourse profile? Do you have any comments to add to discussion about compression? |
Contributor
Author
|
No, I don't have an account. I'm not really knowledgeable on compression so I don't have anything to add to the discussion. |
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Sep 26, 2021
`itkStaticConstMacro(name, type, value)` became unconditionally identical to `static constexpr type name = value` with commit aec9519 "ENH: Update compiler macros (InsightSoftwareConsortium#810)", maekclena, 7 May 2019. `itkGetStaticConstMacro(name)` became unconditionally identical to `(Self::name)` with commit 84e490b "Removing some outdated compiler conditionals", Hans Johnson, 31 July 2010. Most `itkStaticConstMacro` calls were removed by commit 5c14741 "STYLE: Replace itkStaticConstMacro with static constexpr", Hans Johnson, 2 February 2018. Most `itkGetStaticConstMacro` calls were removed by commit d72d28f "STYLE: Do not use itkGetStaticConstMacro in ITK", Hans Johnson, 4 March 2018.
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Sep 26, 2021
`itkStaticConstMacro(name, type, value)` became unconditionally identical to `static constexpr type name = value` with commit aec9519 "ENH: Update compiler macros (InsightSoftwareConsortium#810)", maekclena, 7 May 2019. `itkGetStaticConstMacro(name)` became unconditionally identical to `(Self::name)` with commit 84e490b "Removing some outdated compiler conditionals", Hans Johnson, 31 July 2010. Most `itkStaticConstMacro` calls were removed by commit 5c14741 "STYLE: Replace itkStaticConstMacro with static constexpr", Hans Johnson, 2 February 2018. Most `itkGetStaticConstMacro` calls were removed by commit d72d28f "STYLE: Do not use itkGetStaticConstMacro in ITK", Hans Johnson, 4 March 2018.
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
Apr 19, 2026
Use static constexpr directly now that C++11 conformance is required by all compilers. :%s/itkStaticConstMacro *( *\([^,]*\),[ \_s]*\([^,]*\),\_s*\([^)]*\)) */static constexpr \2 \1 = \3/ge 'itkStaticConstMacro(name, type, value)' became unconditionally identical to 'static constexpr type name = value' with ITK commit aec9519 "ENH: Update compiler macros (InsightSoftwareConsortium#810)", maekclena, 7 May 2019. 'itkGetStaticConstMacro(name)' became unconditionally identical to '(Self::name)' with ITK commit 84e490b "Removing some outdated compiler conditionals", Hans Johnson, 31 July 2010. Most 'itkStaticConstMacro' calls were removed by ITK commit 5c14741
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
Apr 19, 2026
Use static constexpr directly now that C++11 conformance is required by all compilers. :%s/itkStaticConstMacro *( *\([^,]*\),[ \_s]*\([^,]*\),\_s*\([^)]*\)) */static constexpr \2 \1 = \3/ge 'itkStaticConstMacro(name, type, value)' became unconditionally identical to 'static constexpr type name = value' with ITK commit aec9519 "ENH: Update compiler macros (InsightSoftwareConsortium#810)", maekclena, 7 May 2019. 'itkGetStaticConstMacro(name)' became unconditionally identical to '(Self::name)' with ITK commit 84e490b "Removing some outdated compiler conditionals", Hans Johnson, 31 July 2010. Most 'itkStaticConstMacro' calls were removed by ITK commit 5c14741
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
Apr 19, 2026
Use static constexpr directly now that C++11 conformance is required by all compilers. :%s/itkStaticConstMacro *( *\([^,]*\),[ \_s]*\([^,]*\),\_s*\([^)]*\)) */static constexpr \2 \1 = \3/ge 'itkStaticConstMacro(name, type, value)' became unconditionally identical to 'static constexpr type name = value' with ITK commit aec9519 "ENH: Update compiler macros (InsightSoftwareConsortium#810)", maekclena, 7 May 2019. 'itkGetStaticConstMacro(name)' became unconditionally identical to '(Self::name)' with ITK commit 84e490b "Removing some outdated compiler conditionals", Hans Johnson, 31 July 2010. Most 'itkStaticConstMacro' calls were removed by ITK commit 5c14741
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #543.
The required compiler versions come from the ITK Software Guide, book 1, chapter 2. For the Intel compiler I picked the last version compatible with Visual Studio 2010.