Skip to content

Conversation

@jhlegarreta
Copy link
Member

Add Azure Pipelines CI, which supersedes Appveyor, Circle and Travis CI.

Update the README file badges accordingly.

@jhlegarreta
Copy link
Member Author

jhlegarreta commented Mar 23, 2019

The target and image within the project template will surely need some revision. And so will need the definitionId field. Thanks.

Updating the ITK tag to ITK v5 will need to be done soon !

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhlegarreta !

A few comments inline.

I disabled CircleCI, TravisCI, and Appveyor. on this repository.

command: |
curl -L https://raw.githubusercontent.com/InsightSoftwareConsortium/ITK/dashboard/itk_common.cmake -O
- run:
name: Evaluate template
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is needed in the new azure-pipelines.yml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see the missing step in the added file. The CTest driver script is being fetched actually. Where do we need to add it ? Does this apply to all azure-pipelines.yml files? The ITKSplitComponents azure-pipelines.yml does not include it 🤔 .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the ITKModuleTemplate repository, we need to evaluate the template with the defaults,

python -m cookiecutter --no-input /ITKModuleTemplateCookieCutter

Compare ITKModuleTemplate/.circleci/config.yml with ITKModuleTemplate/{{cookiecutter.project_name}}/.circleci/config.yml.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation 👍 . Let's see if I did this correctly in c267ab4.

@jhlegarreta jhlegarreta force-pushed the UseAzurePipelinesForCI branch from 9c0c91b to c267ab4 Compare March 24, 2019 20:33
Add Azure Pipelines CI, which supersedes Appveyor, Circle and Travis CI.

Update the README file badges accordingly.
@jhlegarreta jhlegarreta force-pushed the UseAzurePipelinesForCI branch from c267ab4 to a587ac1 Compare March 25, 2019 02:05
@jhlegarreta
Copy link
Member Author

@thewtex thanks 👍

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhlegarreta !

Let's merge, then I will enable the builds, then we may need to follow up with fixes.

@thewtex thewtex merged commit 0b91ca8 into InsightSoftwareConsortium:master Mar 25, 2019
@jhlegarreta jhlegarreta deleted the UseAzurePipelinesForCI branch March 25, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants