-
Notifications
You must be signed in to change notification settings - Fork 16
ENH: Add Azure Pipelines CI. #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add Azure Pipelines CI. #58
Conversation
|
The target and image within the project template will surely need some revision. And so will need the Updating the ITK tag to ITK v5 will need to be done soon ! |
thewtex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jhlegarreta !
A few comments inline.
I disabled CircleCI, TravisCI, and Appveyor. on this repository.
| command: | | ||
| curl -L https://raw.githubusercontent.com/InsightSoftwareConsortium/ITK/dashboard/itk_common.cmake -O | ||
| - run: | ||
| name: Evaluate template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is needed in the new azure-pipelines.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see the missing step in the added file. The CTest driver script is being fetched actually. Where do we need to add it ? Does this apply to all azure-pipelines.yml files? The ITKSplitComponents azure-pipelines.yml does not include it 🤔 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the ITKModuleTemplate repository, we need to evaluate the template with the defaults,
python -m cookiecutter --no-input /ITKModuleTemplateCookieCutter
Compare ITKModuleTemplate/.circleci/config.yml with ITKModuleTemplate/{{cookiecutter.project_name}}/.circleci/config.yml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation 👍 . Let's see if I did this correctly in c267ab4.
9c0c91b to
c267ab4
Compare
Add Azure Pipelines CI, which supersedes Appveyor, Circle and Travis CI. Update the README file badges accordingly.
c267ab4 to
a587ac1
Compare
|
@thewtex thanks 👍 |
thewtex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jhlegarreta !
Let's merge, then I will enable the builds, then we may need to follow up with fixes.
Add Azure Pipelines CI, which supersedes Appveyor, Circle and Travis CI.
Update the
READMEfile badges accordingly.