ENH: Enable specifying MacOSX deployment target#94
Conversation
std::filesystem requires MACOSX_DEPLOYMENT_TARGET=10.15 or newer.
Before this change, "Build ITK" step had full log,
while "Build and test" step had only superficial output, e.g.:
Configure project
Each . represents 1024 bytes of output
.. Size of output: 1K
Build project
Each symbol represents 1024 bytes of output.
'!' represents an error and '*' a warning.
.........!! Size of output: 11K
Error(s) when building project
1 Compiler errors
1 Compiler warnings
|
The effect of this is demonstrated here: https://github.com/InsightSoftwareConsortium/ITKNornir/actions/runs/11373152688/job/31639097616 |
jhlegarreta
left a comment
jhlegarreta
left a comment
There was a problem hiding this comment.
Looks OK to me.
BTW, why are these two different?
https://github.com/InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/pull/94/files#diff-9e7707c38de1da072f348ce68435700fecb4042cea88776d9ecda206740f925aR169
https://github.com/InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/pull/94/files#diff-9e7707c38de1da072f348ce68435700fecb4042cea88776d9ecda206740f925aR244
|
Probably because |
|
@dzenanz we have to revert this. Distributable Python packages require an older version of the macOS deployment target. |
|
This only allows changing it. The default stay the same. |
|
So far, this was only changed in ITKNornir: Can you point me to an explanation for "Distributable Python packages require an older version of the macOS deployment target." I found this SO answer and this discussion. |
3 participants
std::filesystemrequires MACOSX_DEPLOYMENT_TARGET=10.15 or newer.