Skip to content

Conversation

@jhlegarreta
Copy link
Member

Set the preferred Doxygen documentation style explicityle following the
discussion in:
http://review.source.kitware.com/#/c/23399/

@jhlegarreta
Copy link
Member Author

@phcerdan following the suggestion I made:
http://review.source.kitware.com/#/c/23399/

Thanks !

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jhlegarreta !

Minor grammar note inline.

extracted and formatted into documentation.

Note that ITK prefers the backslash (``\\'') style versus the at-sign (``@'')
style to wrtite the documentation commands.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrtite the -> write

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 4cbb0bd. Thanks @thewtex !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e481462 was rebased on master.

@jhlegarreta jhlegarreta force-pushed the SetTheDoxygenPreferredStyleExplicitly branch from e200ea9 to 4cbb0bd Compare May 6, 2018 10:54
Set the preferred Doxygen documentation style explicityle following the
discussion in:
http://review.source.kitware.com/#/c/23399/
@jhlegarreta jhlegarreta force-pushed the SetTheDoxygenPreferredStyleExplicitly branch from 4cbb0bd to e481462 Compare May 6, 2018 11:15
@jhlegarreta
Copy link
Member Author

jhlegarreta commented May 7, 2018

Thanks @dzenanz. @thewtex I can already merge, but it's nicer if you re-evaluate, approve and thus GitHub would be happy to merge without red warnings 😄 Thanks !

@dzenanz
Copy link
Member

dzenanz commented May 7, 2018

I already approved, but @thewtex's change request is not "outdated".

@jhlegarreta
Copy link
Member Author

Matt's change suggestion has already been addressed in e481462.

@thewtex thewtex merged commit b46f6be into InsightSoftwareConsortium:master May 10, 2018
@thewtex
Copy link
Member

thewtex commented May 10, 2018

Sorry for the delay in the follow-up review -- GitHub does not do a good job at sending me emails 😠

@jhlegarreta jhlegarreta deleted the SetTheDoxygenPreferredStyleExplicitly branch May 12, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants