Feat/folia support#244
Conversation
| } | ||
|
|
||
| getServer().getScheduler().runTaskLater(this, () -> { | ||
| getServer().getGlobalRegionScheduler().runDelayed(this, (scheduledTask) -> { |
There was a problem hiding this comment.
i think that this could use the async scheduler
There was a problem hiding this comment.
I've never tried loading Bukkit.getPluginManager().registerEvents async, does it work?
There was a problem hiding this comment.
Ah, well, it seems to work :
[00:06:18 INFO]: [Insights] Loaded addon 'Skyllia' v1.0
There was a problem hiding this comment.
Afaik it should work, i'll ask around in the paper discord
There was a problem hiding this comment.
Ah, well, it seems to work : [00:06:18 INFO]: [Insights] Loaded addon 'Skyllia' v1.0
Nicee
There was a problem hiding this comment.
[00:12:09 INFO]: [Insights] Registered listener of addon 'Skyllia'
[00:12:09 INFO]: [Insights] Loaded addon 'Skyllia' v1.0
I forgot a line, so I'm editing it.
There was a problem hiding this comment.
After looking at how listeners are registered in Paper/Folia, HandlerList#handlerslots is an EnumMap which is not thread-safe. Therefore, I would suggest simply re-registering it in the global scheduler during startup.
|
lgtm |
3 participants
This PR removes support for Spigot