chore: retire dashboardsvc gRPC service — no longer consumed#14
Merged
Conversation
dashboardsvc was the gRPC bridge consumed by the standalone dashboard-api
Go service. The dashboard frontend now talks directly to the agent API
over HTTP, so the bridge has no remaining consumers.
This change:
- Deletes internal/dashboardsvc/ entirely (server, interceptor,
rotate, stacks, team_members, context, and their tests).
- Removes the gRPC server bootstrap from main.go that listened on
:50052, including the now-orphan storage/stack provider setup
that existed solely to inject deps into dashboardsvc.NewServer.
- Drops the dashboardv1 proto import (companion PR in the proto
repo deletes proto/dashboard/v1/).
go build ./... clean. go vet ./... clean. Test failures unchanged
from master baseline (the same pre-existing TEST_DATABASE_URL-
dependent integration tests skip when no DB is reachable).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mastermanas805
added a commit
to InstaNode-dev/infra
that referenced
this pull request
May 11, 2026
The standalone dashboard-api service is being retired across the platform. The dashboard frontend now talks directly to the agent API at api.instanode.dev for every operation — auth, claim, billing, team, resources, stacks. This manifest was the only k8s artifact for the service (ConfigMap, Deployment, NodePort 30082, all under namespace=instant). No other infra file referenced dashboard-api (verified with grep — no leftover configmap, ingress, networkpolicy, or env-var references). Companion PRs: - InstaNode-dev/instanode-web#21 (dashboard: purge references) - InstaNode-dev/proto#1 (drop dashboard/v1 proto) - InstaNode-dev/api#14 (delete internal/dashboardsvc/) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/dashboardsvc/was the gRPC bridge consumed exclusively by the standalonedashboard-apiGo service. The dashboard frontend now talks directly to this agent API over HTTP, so the bridge has no remaining consumers.internal/dashboardsvc/entirely (server, interceptor, rotate, stacks, team_members, context, plus their tests — 8 files, ~2.2k lines).main.gothat listened on:50052, along with the now-orphan storage/stack provider setup that existed solely to inject deps intodashboardsvc.NewServer.dashboardv1proto import.Coordination
This is PR 2 of 4 in the dashboard-api retirement chain. It depends on:
InstaNode-dev/proto#1— dropsproto/dashboard/v1/(thedashboardv1package this file imported). Land that first or together, since the api repo'sreplace instant.dev/proto => ../protodirective resolves the import locally.InstaNode-dev/instanode-web#21— purges dashboard-api references from the frontend codebase (already landable independently).infra/k8s/dashboard-api.yamlfrom the infra repo and (optionally) archive the dashboard-api repo on GitHub.Test plan
go build ./...cleango vet ./...cleango test ./internal/handlers/...on master with identical FAIL output)grep -rn 'dashboardsvc\\|DashboardService' .that no consumer remains/instant-ship; verify nothing was attached to:50052in production (it was never exposed externally — only consumed bydashboard-api, which itself is being retired)