test(coverage/plans): drive plans to ≥95% (was 82.5%)#26
Merged
Conversation
Cover defensive nil-plan branches, parse() empty-plans guard, ValidatePromotion expiry/skip paths, TeamMemberLimit tier defaults, and QueueCountLimit zero-fallback. White-box tests in package plans build Registry directly to reach branches Get()'s anonymous fallback hides from black-box callers. Module coverage: 82.5% → 99.3%. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plans/plans_coverage_test.gowith white-box tests inpackage plansto reach branches the publicRegistry.Getanonymous fallback hides from black-box callers.parse()empty-plans guard,ValidatePromotionexpiry / skip-non-matching-code paths,TeamMemberLimitper-tier defaults (team/pro/growth/default),QueueCountLimitzero-fallback,VaultEnvsAllowednil-slice branch, and every accessor's defensiveif p == nilbranch.Default()panic branch remains).Test plan
go test ./plans -coverprofile=/tmp/plans-cov.outpassesgo tool cover -func=/tmp/plans-cov.outreports 99.3% totalDefault()panic guard🤖 Generated with Claude Code