dashboard: wire /app/deployments to /api/v1/deployments + drop 'Phase 1 coming soon' lies#35
Merged
Merged
Conversation
… 1 coming soon" lies Today's deploy backend audit (Phase 1) confirmed POST /deploy/new is live — verified by a real e2e test deploy at https://6fffcc21.deployment.instanode.dev (nginx tarball → Kaniko build → k8s pod → Ingress + TLS, 30s). But the dashboard surface was contradicting the working backend: • /app/deployments queried GET /api/v1/stacks (multi-service stack model) instead of GET /api/v1/deployments (single-app /deploy/new path). A team that deployed via /deploy/new saw "No deployments yet" forever. • Empty-state copy literally said "Deployment lands in Phase 1 — for now, use kubectl on your own cluster" — telling users the feature was unbuilt. • DeployDetailPage's EnvVars + BoundResources tabs were hardcoded placeholders saying "Phase 1" + "kubectl get deploy -o yaml". • Log SSE URL pointed at /api/v1/stacks/:slug/logs/:svc — wrong for /deploy/new origin deployments. This PR: • Adds listDeployments() + getDeployment() in src/api/index.ts wired to GET /api/v1/deployments and GET /api/v1/deployments/:id with typed DashboardDeployment shape. • DeploymentsPage now calls listDeployments() first, falls back to listStacks() for legacy multi-service deploys. One unified list. • DeployDetailPage detects /deploy/new origin first (getDeployment by id), falls back to listStacks. Env vars panel parses deployment.env_vars and renders real rows. Bound resources surface from env vars that look like resource tokens. • Log SSE: for /deploy/new origin, calls /deploy/:id/logs; for stack origin, /api/v1/stacks/:slug/logs/:svc. • Drops every "Phase 1 coming soon" placeholder string. Empty state on DeploymentsPage now says "No deployments yet" + points at the agent prompt to deploy. Tests: tsc clean. Dashboard suite passes including the new DeploymentsPage.test.tsx + extended DeployDetailPage.test.tsx cases. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 audit confirmed POST /deploy/new is live (verified e2e). This PR wires the dashboard surface to match.
Test plan
🤖 Generated with Claude Code