fix(api-client): homepage no longer auto-redirects to /login#53
Merged
Merged
Conversation
…epage redirect bug) Root cause: src/api/index.ts had an inverted skip-list — only /login and /claim were excluded from the 401→/login auto-redirect. Any other public route (/, /pricing, /docs, /blog, /use-cases, /status, /incidents) could get bounced to /login if a stray api call from a hook, Suspense boundary, or cached service worker returned 401. Fix: invert the gate. Redirect only when on /app/*. On public routes, clear the stale token silently and throw the APIError to the caller without navigating — the page stays renderable for an anonymous visitor. +1 regression test pinning pathname stability on / when fetchMe returns 401. 92/95 api tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/api/index.ts401-handler had an inverted skip-list — only/loginand/claimwere exempted from the auto-redirect. Any other public route (/,/pricing,/docs,/blog,/use-cases,/status,/incidents) could be bounced to/loginif a stray api call from a hook / Suspense boundary / cached service worker returned 401./app. Public routes clear the stale token silently and throw the APIError to the caller without nav./whenfetchMereturns 401.Test plan
🤖 Generated with Claude Code