fix(dashboard): light up Hobby Plus across upgrade picker, deploy detail, overview (Wave FIX-A)#73
Merged
Merged
Conversation
…ail, overview (Wave FIX-A)
Closes BugBash R9, R16, U11, U15, 190 (dashboard-side share of the wave).
Hobby Plus shipped in api/plans.yaml at W11 ($19/mo, custom_domains: true,
2 deployments, vault_envs_allowed: [development, staging, production]) but
the dashboard kept treating it as a stub — hidden from the upgrade picker,
custom-domain panel showed the upsell instead of the live form, overview
storage bar fell through to the Pro fallback (lying about the limit). This
PR lights it up across every surface so a hobby_plus user sees the same
shape as any other paid customer.
Changes:
- ChangePlanModal: SELECTABLE_TIERS now includes hobby_plus (it's real
in plans.yaml). Dropped growth — no real self-serve growth row exists,
surfacing it sent users into a 400 invalid_plan from the api. The
downgrade-via-support exit path is unchanged.
- DeployDetailPage: CUSTOM_DOMAIN_TIERS (FIX-U11) + MULTI_ENV_TIERS
(FIX-A6/Q23, dashboard-side mirror of the api allowlist) now include
hobby_plus. The api unlocks both for hobby_plus — the dashboard
matches so users don't see the upsell over a feature they already
paid for.
- OverviewPage TIER_LIMIT_GB: added hobby_plus (5) + growth (10). A
hobby_plus user previously hit the `?? 5` fallback (same as Pro);
growth users similarly. The chart now renders the correct ceiling.
- Tier type (src/api/types.ts) gained 'hobby_plus' — this was already
accepted as a server-side string in many places (the api response
carries it) but the TS union was lagging. All Record<Tier, ...>
sites (Common.tsx TIER_LABELS, TierChangeModal.tsx TIER_RANK) +
AdminCustomersPage tier filter were updated to match.
Tests:
- ChangePlanModal.test.tsx: new tests for hobby_plus appearing as an
upgrade target from hobby, growth being hidden (FIX-190), and a
hobby_plus user seeing only pro+team upgrades. 21 tests total
(was 19), 0 failures.
- DeployDetailPage.tier-config.test.tsx: new file. Pins that a
hobby_plus user sees the custom-domain panel and no multi-env
upsell — i.e. the FIX-U11 + FIX-A6 dashboard-side unlocks land.
- OverviewPage.tier-limit.test.tsx: new file. Renders the page for
every plans.yaml tier (anonymous → team) and asserts it doesn't
crash — locks in that the TIER_LIMIT_GB extension covered every
real tier the server can return.
Full suite: 564 passed | 3 skipped (was 555 — 9 new tests). TypeScript
compile clean (npx tsc --noEmit).
Cross-ref: api PR for the server-side share — fix/wave-a-hobby-plus
on InstaNode-dev/api.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes BugBash R9, R16, U11, U15, 190 (dashboard-side share of Wave FIX-A).
Hobby Plus has been a real plan in
api/plans.yamlsince W11 ($19/mo,custom_domains: true, 2 deployments, multi-env vault) but the dashboard kept treating it as a stub — hidden from the upgrade picker, custom-domain panel showed the upsell, overview storage bar fell through to the Pro fallback and lied about the limit. This PR lights it up everywhere.SELECTABLE_TIERSnow includeshobby_plus. Droppedgrowth— no real self-serve growth row exists in plans.yaml; surfacing it sent users into a 400 invalid_plan. The downgrade-via-support exit path is unchanged.CUSTOM_DOMAIN_TIERSandMULTI_ENV_TIERSnow includehobby_plus. The api unlocks both for hobby_plus; the dashboard matches so users don't see upsells over features they paid for.TIER_LIMIT_GBgainedhobby_plus: 5andgrowth: 10. A hobby_plus user previously hit the?? 5fallback (Pro's number) and the usage bar lied about the ceiling.src/api/types.ts):hobby_pluswas already strolling through many response payloads as a string but the TS union was lagging. AllRecord<Tier, ...>sites updated:Common.tsxTIER_LABELS,TierChangeModal.tsxTIER_RANK,AdminCustomersPagetier filter,listAdminCustomersrequest shape.Tests
ChangePlanModal.test.tsx— new tests forhobby_plusappearing as an upgrade target fromhobby,growthstaying hidden (FIX-190), and ahobby_plususer seeing onlypro+teamupgrades. 21 tests (was 19), 0 failures.DeployDetailPage.tier-config.test.tsx(new) — pins that ahobby_plususer sees the custom-domain panel and no multi-env upsell.OverviewPage.tier-limit.test.tsx(new) — renders the page for every plans.yaml tier (anonymous→team) and asserts no crash — locks in that TIER_LIMIT_GB covers every real tier the server can return.(was 555 passed — 9 net new tests.) TypeScript compile clean (
npx tsc --noEmit).Cross-ref
API PR for the server-side share (FIX-A6, R8, R16, Q23): https://github.com/InstaNode-dev/api/pull/102
Test plan
/deployments/:id— see the live custom-domain panel, NOT the upsell card.Closes BugBash R9, R16, U11, U15, 190.
🤖 Generated with Claude Code