Skip to content

Conversation

@TheBuggedYRN
Copy link
Contributor

@TheBuggedYRN TheBuggedYRN commented Sep 28, 2022

Description of the change

Creating a SSOT for enums in JS, has a some of benefits:

  1. Removes duplicate definitions.
  2. Eases sync with native ArgsRegistry.
  3. Declutters Modules files.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@TheBuggedYRN TheBuggedYRN self-assigned this Sep 28, 2022
@TheBuggedYRN TheBuggedYRN changed the title Extract enums to ArgsRegistry [MOB-10149] Extract enums to ArgsRegistry Sep 28, 2022
@TheBuggedYRN TheBuggedYRN force-pushed the refactor/args-registery-js branch from 2f564b1 to 1ee4428 Compare September 28, 2022 14:04
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #781 (29660ac) into master (e477bed) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
+ Coverage   89.96%   89.98%   +0.01%     
==========================================
  Files          22       23       +1     
  Lines         598      599       +1     
  Branches       93       93              
==========================================
+ Hits          538      539       +1     
  Misses         52       52              
  Partials        8        8              
Impacted Files Coverage Δ
src/modules/APM.js 89.28% <ø> (ø)
src/modules/Instabug.js 82.77% <ø> (ø)
src/modules/BugReporting.js 95.91% <100.00%> (ø)
src/modules/FeatureRequests.js 100.00% <100.00%> (ø)
src/utils/ArgsRegistry.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TheBuggedYRN TheBuggedYRN force-pushed the refactor/instabug-module branch 3 times, most recently from a32b08e to 06ed9dd Compare September 29, 2022 07:56
@TheBuggedYRN TheBuggedYRN marked this pull request as ready for review September 29, 2022 09:18
DavidMina96
DavidMina96 previously approved these changes Sep 29, 2022
Base automatically changed from refactor/instabug-module to master September 29, 2022 11:43
@ymabdallah ymabdallah merged commit 792dc64 into master Sep 29, 2022
@ymabdallah ymabdallah deleted the refactor/args-registery-js branch September 29, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants