Skip to content

[INSD-8104] Declare local vars final #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ymabdallah merged 3 commits into from
Oct 3, 2022
Merged

[INSD-8104] Declare local vars final #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afe0784
Declare local var final
DavidMina96 Oct 3, 2022
db45929
Update CHANGELOG.md
DavidMina96 Oct 3, 2022
96feec2
Update CHANGELOG.md
DavidMina96 Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## Unreleased

* Uses Cocoapods for Instabug iOS SDK
* Fixes a compilation error on projects with Java version prior to 8.

## 11.2.0 (2022-09-19)

Expand Down
4 changes: 2 additions & 2 deletions android/src/main/java/com/instabug/reactlibrary/RNInstabugBugReportingModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ public void run() {
* @see InstabugInvocationEvent
*/
@ReactMethod
public void setInvocationEvents(ReadableArray invocationEventValues) {
public void setInvocationEvents(final ReadableArray invocationEventValues) {
MainThreadHandler.runOnMainThread(new Runnable() {
@Override
public void run() {
Expand Down Expand Up @@ -324,7 +324,7 @@ public void run() {
* @see BugReporting.ReportType
*/
@ReactMethod
public void setReportTypes(ReadableArray types) {
public void setReportTypes(final ReadableArray types) {
MainThreadHandler.runOnMainThread(new Runnable() {
@SuppressLint("WrongConstant")
@Override
Expand Down
2 changes: 1 addition & 1 deletion android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ public void run() {
* @see InstabugInvocationEvent
*/
@ReactMethod
public void setInvocationEvents(ReadableArray invocationEventValues) {
public void setInvocationEvents(final ReadableArray invocationEventValues) {
MainThreadHandler.runOnMainThread(new Runnable() {
@Override
public void run() {
Expand Down