Skip to content

Conversation

@a7medev
Copy link
Contributor

@a7medev a7medev commented Oct 3, 2022

Description of the change

Enables and fixes the "should emit event IBGSendUnhandledJSCrash when platform is android and onReportSubmitHandler is set" InstabugUtils disabled test.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev changed the title [CP] [RN] Enable Disabled InstabugUtils Test [MOB-10372] Enable Disabled InstabugUtils Test Oct 3, 2022
@a7medev a7medev self-assigned this Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #792 (d1f21cb) into master (875e79e) will increase coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
+ Coverage   86.54%   87.04%   +0.49%     
==========================================
  Files          14       14              
  Lines         602      602              
  Branches      103      103              
==========================================
+ Hits          521      524       +3     
+ Misses         68       66       -2     
+ Partials       13       12       -1     
Impacted Files Coverage Δ
src/utils/InstabugUtils.js 51.02% <0.00%> (+6.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from test/enhance-test-structure to master October 3, 2022 20:25
@AliAbdelfattah AliAbdelfattah marked this pull request as draft October 4, 2022 08:56
@a7medev a7medev force-pushed the test/enable-utils-emit-event-on-android-test branch from 26bed0a to d1f21cb Compare October 4, 2022 12:48
@a7medev a7medev marked this pull request as ready for review October 4, 2022 14:43
@ymabdallah ymabdallah merged commit 082f018 into master Oct 5, 2022
@ymabdallah ymabdallah deleted the test/enable-utils-emit-event-on-android-test branch October 5, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants