Conversation
Contributor
Author
|
THE BUILD IS GREEN 🌮🌮🌮 |
jessesquires
approved these changes
Feb 3, 2018
Contributor
jessesquires
left a comment
jessesquires
left a comment
There was a problem hiding this comment.
Sounds good to me! 💯
Contributor
|
Oh one more thing -- I think you need to open up the macOS example project and update all the targets |
Contributor
Author
|
@jessesquires good catch yup, updating then landing Sent with GitHawk |
Contributor
Contributor
Contributor
Author
|
Gonna wait on green again now that examples and stuff have been updated. Funny enough, the macOS example was already set to 10.11, probably b/c it was crashing w/out it. edit: looks like bot is working |
Generated by 🚫 Danger |
Contributor
Author
|
Alright still green, landing |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rnystrom is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup from #1068
The
NSIndexPathmethods we use are not available <10.11. In theory this has always been "broken" b/c older macOS versions would crash at runtime when trying to use these methods.Normally this would be breaking change, but I can't imagine anyone is using IGListKit on the mac targeting 10.10 and shipping a working app.
cc @jessesquires for thoughts
This should be the last remaining item before we get a green badge.
(note that 10.11 was released 9/30/15 which is about 2 weeks before the public IGListKit release)