Fixed tail loading example (#105)#109
Conversation
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
rnystrom
left a comment
rnystrom
left a comment
There was a problem hiding this comment.
Love these changes, but could we keep the IGListSingleSectionController? With that I think we're g2g.
|
|
||
| func didUpdate(to object: Any) { | ||
| self.object = object as? String | ||
| self.object = String(describing: object) |
|
|
||
| func cellForItem(at index: Int) -> UICollectionViewCell { | ||
| let cell = collectionContext!.dequeueReusableCell(of: SpinnerCell.self, for: self, at: index) as! SpinnerCell | ||
| cell.activityIndicator.startAnimating() |
There was a problem hiding this comment.
Could we just update the function using IGListSingleSectionController to call startAnimating() in the configureBlock(...) instead of making a new section controller?
I just want to make sure we have an example using the single section controller somewhere.
| let collectionView = IGListCollectionView(frame: CGRect.zero, collectionViewLayout: UICollectionViewFlowLayout()) | ||
|
|
||
| lazy var words = "Maecenas faucibus mollis interdum Praesent commodo cursus magna, vel scelerisque nisl consectetur et".components(separatedBy: " ") | ||
| lazy var items = Array(0...20) |
There was a problem hiding this comment.
Agree w/ this, makes it much more clear that we're appending new data.
| } | ||
| return items | ||
|
|
||
| return objects |
|
@Sherlouk updated the pull request - view changes |
| { | ||
| "images" : [ | ||
| { | ||
| "idiom" : "iphone", |
There was a problem hiding this comment.
Had told it not to commit this 🤔
Xcode be really wanting this change to happen!
|
@Sherlouk updated the pull request - view changes |
| let configureBlock = { (item: Any, cell: UICollectionViewCell) in} | ||
| let configureBlock = { (item: Any, cell: UICollectionViewCell) in | ||
| guard let cell = cell as? SpinnerCell else { return } | ||
| cell.activityIndicator.startAnimating() |
|
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
3 participants
Changes in this pull request
Added a 'SpinnerSectionController' allowing us to trigger the activity spinner each timePull request checklist