Closed
Conversation
Contributor
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Contributor
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
hanton
force-pushed
the
fix/SwiftLine_warnings
branch
from
5424984 to
a68fa2f
Compare
[√]Operator Usage Whitespace Violation: Operators should be surrounded by a single whitespace when they are being used. (operator_usage_whitespace) [√]Sorted Imports Violation: Imports should be sorted. (sorted_imports) [√] Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
hanton
force-pushed
the
fix/SwiftLine_warnings
branch
from
a68fa2f to
d0718ae
Compare
Contributor
|
Thank you!! |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rnystrom is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
TimOliver
pushed a commit
that referenced
this pull request
Dec 10, 2025
Summary: Issue fixed: SwiftLint warnings - [x] Operator Usage Whitespace Violation: Operators should be surrounded by a single whitespace when they are being used. (operator_usage_whitespace) - [x] Sorted Imports Violation: Imports should be sorted. (sorted_imports) - [x] Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace) - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: #1283 Differential Revision: D13237028 Pulled By: rnystrom fbshipit-source-id: b364f329b0e99ca56704d3d2851cf225759b2a78
TimOliver
pushed a commit
that referenced
this pull request
Dec 10, 2025
Summary: Issue fixed: SwiftLint warnings - [x] Operator Usage Whitespace Violation: Operators should be surrounded by a single whitespace when they are being used. (operator_usage_whitespace) - [x] Sorted Imports Violation: Imports should be sorted. (sorted_imports) - [x] Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace) - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: #1283 Differential Revision: D13237028 Pulled By: rnystrom fbshipit-source-id: b364f329b0e99ca56704d3d2851cf225759b2a78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Issue fixed: SwiftLint warnings
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.