Skip to content

Fix missing project and SPM references#1621

Closed
bartoszpawelczyk wants to merge 3 commits intoInstagram:mainfrom
bartoszpawelczyk:main
Closed

Fix missing project and SPM references#1621
bartoszpawelczyk wants to merge 3 commits intoInstagram:mainfrom
bartoszpawelczyk:main

Conversation

@bartoszpawelczyk
Copy link
Copy Markdown
Contributor

@bartoszpawelczyk bartoszpawelczyk commented Mar 11, 2025

Changes in this pull request

Issue fixed: 1620

Checklist

  • All tests pass. Demo project builds and runs.
  • I added tests, an experiment, or detailed why my change isn't tested.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • I have reviewed the contributing guide

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @bartoszpawelczyk!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@TimOliver has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@TimOliver merged this pull request in 24eee66.

TimOliver pushed a commit that referenced this pull request Dec 10, 2025
Summary:
## Changes in this pull request

Issue fixed: [1620](#1620)

### Checklist

- [ ] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md)

Pull Request resolved: #1621

Test Plan:
Tested that IG builds with these changes without issue. All seems good.
As

Reviewed By: NSProgrammer

Differential Revision: D70959852

Pulled By: TimOliver

fbshipit-source-id: 087411463ad1b7c0698d7aba543d85c9013abf39
TimOliver pushed a commit that referenced this pull request Dec 10, 2025
Summary:
## Changes in this pull request

Issue fixed: [1620](#1620)

### Checklist

- [ ] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md)

Pull Request resolved: #1621

Test Plan:
Tested that IG builds with these changes without issue. All seems good.
As

Reviewed By: NSProgrammer

Differential Revision: D70959852

Pulled By: TimOliver

fbshipit-source-id: 087411463ad1b7c0698d7aba543d85c9013abf39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compile error

4 participants