IGListIndexSetResult and IGListIndexPathResult docs updates use old index#413
Closed
diogot wants to merge 1 commit into
Closed
IGListIndexSetResult and IGListIndexPathResult docs updates use old index#413diogot wants to merge 1 commit into
diogot wants to merge 1 commit into
Conversation
Contributor
Author
|
Is it necessary to add anything to |
2 tasks
1 similar comment
Contributor
|
Thanks @diogot! No don't worry about the changelog 😄 |
Contributor
|
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jessesquires
pushed a commit
that referenced
this pull request
Jan 13, 2017
…ndex Summary: Updated documentation to fix #408 - [X] All tests pass. Demo project builds and runs. - [X] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes #413 Differential Revision: D4415035 Pulled By: rnystrom fbshipit-source-id: 2c477c515c6f1346ce6db48d4ba865099cf197cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Updated documentation to fix #408
Pull request checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.