Fix Twitter handles in Example project#54
Closed
BalestraPatrick wants to merge 1 commit intoInstagram:masterfrom
Closed
Fix Twitter handles in Example project#54BalestraPatrick wants to merge 1 commit intoInstagram:masterfrom
BalestraPatrick wants to merge 1 commit intoInstagram:masterfrom
Conversation
Contributor
|
Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email cla@fb.com with your details so we can update your status. |
Contributor
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Contributor
|
Omg, sorry @jessesquires and @ryanolsonk 😂 |
Contributor
|
Thanks for importing. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
lol |
| GridItem(color: UIColor(red: 56/255.0, green: 151/255.0, blue: 240/255.0, alpha: 1), itemCount: 5), | ||
| "Nullam quis risus eget urna mollis ornare vel eu leo. Praesent commodo cursus magna, vel scelerisque nisl consectetur et.", | ||
| User(pk: 3, name: "Jessie Squires", handle: "ryanolson"), | ||
| User(pk: 3, name: "Jessie Squires", handle: "jesse_squires"), |
Contributor
There was a problem hiding this comment.
lol. missed this too.
s/Jessie/Jesse
Contributor
There was a problem hiding this comment.
Jazzy Squirrels
(i'll never get this right)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
I was exploring the example project when I noticed that two Twitter handles were wrong.
This will probably be the most useless PR ever in
IGListKit, but it's good that you guys get the correct acknowledgment for your hard work! 🤓Pull request checklist