Simplify header height check in layout#565
Closed
PhilCai1993 wants to merge 1 commit intoInstagram:masterfrom
Closed
Simplify header height check in layout#565PhilCai1993 wants to merge 1 commit intoInstagram:masterfrom
PhilCai1993 wants to merge 1 commit intoInstagram:masterfrom
Conversation
Generated by 🚫 Danger |
Contributor
|
I'll update the contributing guide to callout that you can add #trival to the build for danger to ignore changelog entries. Nice change! Danger is failing the build, but its fine. |
Contributor
|
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Issue fixed: #
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.Small changes