Chore/variable accessibility, close #618 #637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesquires
suggested changes
Apr 11, 2017
Contributor
jessesquires
left a comment
jessesquires
left a comment
There was a problem hiding this comment.
Thanks @heshamsalman ! 💯
Overall looks, only one thing to address. 😄
| didSet { | ||
| titleLabel.text = title | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
i'm not a fan of these changes on all of the cells. the properties are redundant, and create unnecessary storage.
if we do something like this, they should be computed, not stored:
var title: String? {
get {
return titleLabel.text
}
set {
titleLabel.text = newValue
}
}
Contributor
Author
There was a problem hiding this comment.
Ooh. I like that quite a bit better 👍
Contributor
|
@heshamsalman updated the pull request - view changes |
jessesquires
approved these changes
Apr 11, 2017
Contributor
jessesquires
left a comment
jessesquires
left a comment
There was a problem hiding this comment.
looks good. thanks @heshamsalman ! 🎉
Contributor
|
@jessesquires has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This was referenced Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Issue fixed: #618
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.