Skip to content

Updated script to pin SwiftLint version#854

Closed
Iron-Ham wants to merge 2 commits intomasterfrom
chore/swiftlint_version_pin
Closed

Updated script to pin SwiftLint version#854
Iron-Ham wants to merge 2 commits intomasterfrom
chore/swiftlint_version_pin

Conversation

@Iron-Ham
Copy link
Copy Markdown
Contributor

Changes in this pull request

Issue fixed: #847

Pinned SwiftLint to 20.1

@jessesquires
Copy link
Copy Markdown
Contributor

Awesome! 🙌

Thanks @heshamsalman ! 💯

Copy link
Copy Markdown
Contributor

@jessesquires jessesquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question/comment -- can we keep this script in one place?

For example, have /scripts/lint.sh and invoke that from each project?

@jessesquires jessesquires modified the milestone: 3.1.0 Jul 12, 2017
@rnystrom
Copy link
Copy Markdown
Contributor

+1 @jessesquires to putting it someplace shared

@Iron-Ham
Copy link
Copy Markdown
Contributor Author

@jessesquires I don't see why not 👍

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@heshamsalman updated the pull request - view changes

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Iron-Ham Iron-Ham deleted the chore/swiftlint_version_pin branch July 12, 2017 19:23
@jessesquires
Copy link
Copy Markdown
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update build script to expect specific version of SwiftLint

4 participants