Skip to content

Comments

[CI] add Fixit to tox -e lint#386

Merged
jimmylai merged 1 commit intoInstagram:masterfrom
jimmylai:run_fixit
Sep 10, 2020
Merged

[CI] add Fixit to tox -e lint#386
jimmylai merged 1 commit intoInstagram:masterfrom
jimmylai:run_fixit

Conversation

@jimmylai
Copy link
Contributor

@jimmylai jimmylai commented Sep 9, 2020

Summary

  • add Fixit to tox -e lint
  • run apply_fix except for UseFstringRule and CompareSingletonPrimitivesByIsRule.
    • UseFstringRule: f-string is only supported in Python 3.6. Use f-string requires drop the support of Python 3.5 which is probably ok. Leave as future work.
    • CompareSingletonPrimitivesByIsRule has an issue and the autofix was wrong. Will follow up in Fixit.

Test Plan

CI builds

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2020
@jimmylai jimmylai merged commit 6a02e2e into Instagram:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zsol zsol Awaiting requested review from zsol

@Kronuz Kronuz Awaiting requested review from Kronuz

1 more reviewer

@luciawlli luciawlli luciawlli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimmylai @luciawlli @facebook-github-bot