Skip to content

Comments

[CI] move test coverage job as a separate job and disable Codecov status comment#48

Merged
jimmylai merged 1 commit intoInstagram:masterfrom
jimmylai:coverage1
Aug 27, 2019
Merged

[CI] move test coverage job as a separate job and disable Codecov status comment#48
jimmylai merged 1 commit intoInstagram:masterfrom
jimmylai:coverage1

Conversation

@jimmylai
Copy link
Contributor

@jimmylai jimmylai commented Aug 23, 2019

Summary

move test coverage job as a separate job and change Codecov status as patch mode which only report percentage comes from current PR changes (rather than focus on project status).

Test Plan

jimmylai-mbp:LibCST jimmylai$ curl --data-binary @codecov.yml https://codecov.io/validate
Valid!

{
  "coverage": {
    "status": {
      "project": false,
      "patch": true
    }
  }
}

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 23, 2019
@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         112      112           
  Lines        6745     6745           
=======================================
  Hits         6461     6461           
  Misses        284      284

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab56f4...75218d8. Read the comment docs.

@jimmylai jimmylai changed the title [CI] move test coverage job as a separate job [CI] move test coverage job as a separate job and disable Codecov status comment Aug 23, 2019
@jimmylai jimmylai requested a review from DragonMinded August 23, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants