Upgrade to µsort 1.0.0rc1, and apply formatting changes#565
Upgrade to µsort 1.0.0rc1, and apply formatting changes#565amyreese merged 3 commits intoInstagram:mainfrom
Conversation
stubs/tokenize.pyi
Outdated
| def __repr__(self) -> str: | ||
| ... | ||
|
|
||
|
|
||
| def detect_encoding(readline: Callable[[], bytes]) -> Tuple[str, Sequence[bytes]]: | ||
| ... | ||
|
|
||
|
|
||
| def tokenize(readline: Callable[[], bytes]) -> Generator[TokenInfo, None, None]: | ||
| ... |
There was a problem hiding this comment.
Looks like this could/should be reported as a bug on µfmt for not detecting/telling black that it's formatting a type stub.
|
@zsol I don't see any excludes configured in pyproject.toml, but you mentioned them on facebook/usort#62; are those needed to get a clean CI pass? |
|
Ah, I had to add them in the rust branch over here: https://github.com/zsol/LibCST/blob/parser/pyproject.toml#L5-L6 |
|
There are some relevant changes you'll need to do from zsol@6925202 to get the failing tests to pass. Check out |
Codecov Report
@@ Coverage Diff @@
## main #565 +/- ##
=======================================
Coverage 94.62% 94.62%
=======================================
Files 240 240
Lines 23389 23389
=======================================
Hits 22132 22132
Misses 1257 1257
Continue to review full report at Codecov.
|
|
I rebased after merging the commit mentioned above, re-applied formatting and codegen changes to the PR. |
zsol
left a comment
There was a problem hiding this comment.
Changes look good to me, feel free to merge if CI is green
Summary
Upgraded µsort and µfmt in requirements. Ran
ufmt format *.Test Plan
Manual diff inspection and CI