Sky culture converter20062025#101
Merged
MherMnatsakanyan03 merged 23 commits intomasterfrom Jun 28, 2025
Merged
Conversation
Collaborator
MherMnatsakanyan03
commented
Jun 21, 2025
MherMnatsakanyan03
commented
- Added SkyCultureConverter via "convert" button in start dialog
- scc plugin gets downloaded via cpm
- option to disable it via "-DSCM_SHOULD_ENABLE_CONVERTER=Off"
- automatic disabling when Qt Version 5
- convertion happens in parrallel thread, so that ui-thread is not stuck possibly
… and adjust CMake configuration
MherMnatsakanyan03
requested review from
Integer-Ctrl,
RivinHD,
ZeyxRew and
xLPMG
Closed
Closed
Closed
RivinHD
requested changes
Jun 21, 2025
| SET(SCM_VERSION "0.1.0") | ||
|
|
||
| # download CPM.cmake | ||
| file( |
Collaborator
There was a problem hiding this comment.
Use uppercase on all cmake 'functions' to align with the other CMakeLists of stellarium
Collaborator
|
I have an issue when I try to convert the .rar file you provided. Is this intended? I also have the issue that the file can not be moved. Use absolute path instead of relative paths (also for the error messages). |
RivinHD
requested changes
Jun 24, 2025
Collaborator
There was a problem hiding this comment.
On conversion failure, it somehow deleted my complete stellarium fork. Luckily, if failed on removing the running stellarium.exe.
The tempDirPath and tempDirPath directories are still there.
Probably some mistake in the moveConvertedFiles.
Any maybe also related to the current working driectory of the stellarium.
| // Important: the converter checks if the destination folder already exists | ||
| // and will not overwrite it, so we do not create it here. | ||
| // If the destination folder already exists, the converter will return an error. | ||
| const QString tempDestDirPath = QDir::tempPath() + "/skycultures/results/" + stem; |
Collaborator
|
The conversion window looks fine now. |
RivinHD
approved these changes
Jun 26, 2025
xLPMG
approved these changes
Jun 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.