Skip to content

Add wait-for-region-colour (appear/vanish)#331

Merged
JE-Chen merged 2 commits into
devfrom
feat/wait-color-batch
Jun 22, 2026
Merged

Add wait-for-region-colour (appear/vanish)#331
JE-Chen merged 2 commits into
devfrom
feat/wait-color-batch

Conversation

@JE-Chen

@JE-Chen JE-Chen commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Round-11, automation-core. wait_for_pixel matches one point exactly and wait_until_pixel_changes detects any change at one point — neither waits for "the status light turns green" / "the progress bar fills" / "the red banner is gone".

Layers

  • Headless core: extends smart_waits/waits.pywait_until_color (counts pixels within tolerance of target_rgb over a region; succeeds when the fraction crosses min_fraction, or drops below it for present=False) + pure _color_fraction helper. Injectable sampler. Returns the existing WaitOutcome.
  • Facade: wait_until_color re-exported + __all__.
  • Executor: AC_wait_color (JSON target_rgb/region).
  • MCP: ac_wait_color.
  • Script Builder: one CommandSpec under Flow.

Tests / docs

  • test/unit_test/headless/test_wait_color_batch.py — 8 headless tests (reaches fraction, timeout, vanish, tolerance band, validation, pure fraction helper + wiring + facade) via injected sampler.
  • EN/Zh feature docs v121_features_doc.rst + toctrees; 3 WHATS_NEW entries.

Note: Codacy may show action_required from its coverage gate only (issues=0); SonarCloud + all GitHub Actions are the substantive gates.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@JE-Chen JE-Chen merged commit a93fa19 into dev Jun 22, 2026
15 of 16 checks passed
@JE-Chen JE-Chen deleted the feat/wait-color-batch branch June 22, 2026 17:32
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant