Add 1-D barcode decoding (read_barcodes)#368
Merged
Merged
Conversation
QR codes were decodable but not the EAN/UPC/Code-128 barcodes on physical goods and shipping labels. Decode them via cv2.barcode with an injectable decoder seam so the path is headless-testable and degrades to [] when the OpenCV build lacks the barcode module.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 18 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
read_barcodes— decode 1-D barcodes (EAN-13/8, UPC-A, Code-128) off the screen or an image via OpenCV'scv2.barcode.BarcodeDetector. Closes the gap left byread_qr(QR-only).The decode step is an injectable seam: the default decoder calls OpenCV; tests pass their own
decoder. The path is fully headless-testable and degrades gracefully — an OpenCV build without thebarcodemodule returns[]instead of raising. Grayscale conversion reuses the sharedvisual_matchhaystack loader (no new image-loading code). Qt-free.Layers
utils/barcode/—read_barcodes(source=None, *, region=None, decoder=None)→ list of{text, type, points}.je_auto_control+__all__.AC_read_barcodes(source/region→{count, barcodes}).ac_read_barcodes(read-only).Tests
test/unit_test/headless/test_barcode_batch.py— injected decoder, decoder-receives-image, blank→empty, full wiring (executor/MCP/Script Builder), facade exports. 5 passed. ruff / bandit / radon / float-scan / Qt-free all clean.