Conversation
The 45 min timeout was set when the bundle was CLI-only. Adding PySide6 to the bundle made the cold build run ~70 min on a fresh runner because Qt's C++ link step is huge. The matrix job hit the timeout and aborted the whole release pipeline (publish-release never ran -> draft stayed unpublished -> Releases sidebar empty). Two fixes: 1. Bump timeout-minutes from 45 to 90. Cold PySide6 builds run 50-70 min; warm builds with cache stay around 5-10 min so the higher cap is rarely paid in practice. 2. Drop --include-package=PySide6 and --include-package-data=PySide6. --enable-plugin=pyside6 already handles both. Stacking the three together caused redundant scanning that roughly doubled compile time. 3. Add --noinclude-data-files for PySide6/qml, PySide6/translations, PySide6/resources. We use QtWidgets only (no QML, no QtQuick3D), so the QML tree is dead weight - Nuitka was emitting hundreds of 'Including QML file ... unlikely to work' warnings, all for code the GUI never touches. Dropping translations and resources too since the UI ships its own en/zh-tw label table.
Reverts the QML / translations / resources exclusions added in the previous commit. The Deck tab planned for the next iteration will likely pull in QtQuick / rich-text features that the current QtWidgets-only Search + Settings tabs do not need, and trimming the bundle now would mean stitching them back in later. The size hit on a single Windows .exe is acceptable; the user explicitly said shipping the full PySide6 tree is fine. The 90-min timeout from the previous commit stays - cold PySide6 builds still need that headroom even without the noinclude trimming (the trimming saved maybe 10-15 min, not 45).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two-commit follow-up to PR #4 (whose Nuitka build hit the 45-min timeout cap on a cold runner, leaving `v0.1.1` / `v0.1.2` stuck as drafts):
Test plan