Silence Codacy Bandit B105 false positive in executor leak test#63
Merged
Silence Codacy Bandit B105 false positive in executor leak test#63
Conversation
Codacy/Bandit flagged the literal string assigned to FA_EXEC_SECRET as a hardcoded password (B105). Switch to pytest's monkeypatch (matching test_substitution.py's existing pattern), rename the env var so the key itself does not contain "SECRET", and use a non-credential-looking sentinel value. Behaviour under test is unchanged.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #61 added
test_substitute_does_not_leak_into_result_keywith a literalos.environ["FA_EXEC_SECRET"] = "TOP_SECRET"to verify substituted env values don't leak into result keys. Codacy/Bandit flagged this as B105 — Possible hardcoded password (PR #62 / dev → main blocked on it).This is a test-only false positive — the literal is a deliberately recognisable sentinel, not a credential. Refactor instead of suppressing:
monkeypatch(matching the existing pattern intest_substitution.py); auto-cleans, no try/finally needed.Behaviour under test is unchanged — still proves the un-substituted literal stays in the result key while the expanded value only reaches the callable.
Test plan
pytest tests/test_action_executor.py— 13 passed locally