Conversation
Fix 31 ruff violations (unused imports, semicolons, inline statements, f-string noise, module-level import order) and add return/parameter type annotations across 63 files covering utils, code_scan, git_client, and all pyside_ui layers. Public APIs, private helpers, __init__ and parameters now carry explicit types (Qt event classes, QModelIndex, Callable, specific widget/model types rather than bare None).
- Document static analysis rules in CLAUDE.md (complexity, exception handling, security, resource management) - Replace broad except Exception: pass with specific exception types and debug-level logging in git_action, base_process_manager, git_client_gui - Replace print() with jeditor_logger in watchdog_thread and json_process - Annotate intentional shell=True in shell_exec with nosec/noqa and rationale
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 2 critical |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
TIP This summary will be updated as you push new changes. Give us feedback
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
except Exception: passwith specific exception types + debug logging acrossgit_action.py,base_process_manager.py,git_client_gui.pyprint()diagnostics withjeditor_loggerinwatchdog_thread.pyandjson_process.pyshell=Trueinshell_exec.pywith# noqa: S602 # nosec B602and rationaleTest plan
pytestpasses