This repository was archived by the owner on Dec 15, 2025. It is now read-only.
Add webUI port auto probe & refactor the example jars auto probe #319
Merged
carsonwang merged 2 commits intoIntel-bigdata:6.0from Oct 10, 2016
Merged
Add webUI port auto probe & refactor the example jars auto probe #319carsonwang merged 2 commits intoIntel-bigdata:6.0from
carsonwang merged 2 commits intoIntel-bigdata:6.0from
Conversation
…tion to auto probe webUI port number
carsonwang
suggested changes
Oct 9, 2016
| if result != "": | ||
| return result | ||
| assert 0, "The pattern " + filename_pattern + \ | ||
| " matches no files, please set `hibench.hadoop.examples.jar` manually" |
Collaborator
There was a problem hiding this comment.
This is a common method used by multiple callers. Can you correct the error message or show the error message by the caller?
| assert spark_home, "`hibench.spark.home` undefined, please fix it and retry" | ||
| join = os.path.join | ||
| spark_env_file = join(spark_home, "conf/spark-env.sh") | ||
| master_port = default_port |
Collaborator
There was a problem hiding this comment.
This is a common method and also used to probe slave's port. Can you rename master_port to a common name like port?
Contributor
Author
There was a problem hiding this comment.
Also done in the next commit
gcz2022
force-pushed
the
probe_examples_uiport
branch
from
868d4a8 to
b3af352
Compare
carsonwang
approved these changes
Oct 10, 2016
Collaborator
|
Thanks @gczsjdy ! |
carsonwang
pushed a commit
to carsonwang/HiBench
that referenced
this pull request
Nov 7, 2016
…el-bigdata#319) * Refactor the functions to auto probe example(test) jars, add the function to auto probe webUI port number * Change the variable name to serve more general cases
carsonwang
pushed a commit
that referenced
this pull request
Nov 8, 2016
* Refactor the functions to auto probe example(test) jars, add the function to auto probe webUI port number * Change the variable name to serve more general cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the functions to auto probe example(test) jars, add the function to auto probe Spark master/worker webUI