This repository was archived by the owner on Dec 15, 2025. It is now read-only.
Fix report behavior bug#340
Merged
carsonwang merged 9 commits intoIntel-bigdata:6.0from Oct 28, 2016
Merged
Conversation
Update to the latest version
update from intel-HiBench
update from intell-HiBench 6.0
carsonwang
reviewed
Oct 28, 2016
| import re | ||
| import urllib | ||
| import socket | ||
| import sys, os, glob, re, urllib, socket |
Collaborator
There was a problem hiding this comment.
What is the style suggested by PEP8? @gczsjdy
carsonwang
reviewed
Oct 28, 2016
| workload_config_file = abspath(workload_config_file) | ||
|
|
||
| # get current workload job name and store it in workload_job | ||
| (dir,workload_job) = os.path.split(workload_folder) |
Collaborator
There was a problem hiding this comment.
workload_job is acutally the framework name (spark, hadoop, prepare) right? Can we rename it to framework_name although prepare is not a framework.
Contributor
Author
There was a problem hiding this comment.
Yeah, workload_job is framework name such as spark, hadoop, prepare, etc.
Ok, I will rename it.
carsonwang
reviewed
Oct 28, 2016
| raise Exception( | ||
| "Please supply <conf root path>, <workload root path>, <workload folder path> [<patch config lists, seperated by comma>") | ||
| conf_root, workload_config, workload_name = sys.argv[ | ||
| conf_root, workload_configFile, workload_folder = sys.argv[ |
Collaborator
There was a problem hiding this comment.
The original style seems to be strange here? @gczsjdy, can you check all similar occurrences later in another PR ?
PEP8 limits all lines to a maximum of 79 characters. May be we can make it to 100 characters as an exception, just like Spark's python code.
carsonwang
pushed a commit
to carsonwang/HiBench
that referenced
this pull request
Nov 7, 2016
carsonwang
pushed a commit
that referenced
this pull request
Nov 8, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix report folder behavior bug and test "wordcount" report behavior.