Improve Kalshi REST adapter with pagination and nested markets#2
Merged
hudsonaikins merged 3 commits intomainfrom Sep 6, 2025
Merged
Improve Kalshi REST adapter with pagination and nested markets#2hudsonaikins merged 3 commits intomainfrom
hudsonaikins merged 3 commits intomainfrom
Conversation
…ensitive filtering - Add _paginate_events for cursor-based pagination on /events - Update get_game_markets to use events with nested markets, flatten, fallback - Update get_nfl_markets and get_cfb_markets with robust filtering and week support - Update get_events to support with_nested_markets and cursor - Remove unused KalshiAuth import - Normalize string matching for case insensitivity
…rces, scripts, and docs updates
- Add comprehensive unit tests for edge cases: empty responses, network failures, pagination - Enhance docstrings with example usage for new parameters - Test coverage for _paginate_events, get_game_markets, get_nfl_markets, get_cfb_markets, get_events, health_check
hudsonaikins
added a commit
that referenced
this pull request
Oct 11, 2025
Fixes #1 (Twitter API domain), #2 (import mismatch), #3/#13 (NumPy compatibility), #4/#12 (Kalshi game discovery), #5 (SSL certs), #11 (WebSocket auth docs), #14 (WebSocket market_tickers parameter) BREAKING CHANGES: None - all changes are backward compatible Changes: - Fix Twitter API base URL from twitter-api.io to api.twitterapi.io - Fix Twitter authentication headers (x-api-key format) - Fix KalshiAPISource import name (KalshiApiSource) - Fix get_nfl_games() and get_cfb_games() series_ticker field usage - Add market_tickers parameter to WebSocket subscribe() method - Add certifi dependency for SSL certificate verification - Document NumPy <2.0 requirement with inline comments - Add comprehensive WebSocket authentication documentation Documentation: - Add BUG_FIXES_COMPLETED.md with deployment guide - Add BETA_BUGS_TRACKING.md with all bug reports - Add SDK_FIXES_REQUIRED.md with technical specifications - Add WEBSOCKET_INTEGRATION_GUIDE.md with usage patterns - Add LIVE_TESTING_FINDINGS.md with test results Testing: - All existing tests pass - No new linter errors - Verified fixes address reported issues See BUG_FIXES_COMPLETED.md for full details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance Kalshi REST adapter for better market discovery.
Changes:
Why:
Testing: