feat: add public CI, Homebrew, and benchmark assets#32
Merged
Conversation
Comment on lines
+27
to
+29
| git -C "${TMP_DIR}/tap" add Formula/profitctl.rb | ||
| git -C "${TMP_DIR}/tap" commit -m "chore: update profitctl formula" | ||
| git -C "${TMP_DIR}/tap" push origin HEAD |
There was a problem hiding this comment.
Missing git user identity before commit
git commit requires user.email and user.name to be configured. In a fresh CI environment (e.g., GitHub Actions runner), these are not set by default, so line 28 will fail with "Please tell me who you are." The script's set -euo pipefail will surface this as a hard exit without a clear error message.
Suggested change
| git -C "${TMP_DIR}/tap" add Formula/profitctl.rb | |
| git -C "${TMP_DIR}/tap" commit -m "chore: update profitctl formula" | |
| git -C "${TMP_DIR}/tap" push origin HEAD | |
| git -C "${TMP_DIR}/tap" config user.email "github-actions[bot]@users.noreply.github.com" | |
| git -C "${TMP_DIR}/tap" config user.name "github-actions[bot]" | |
| git -C "${TMP_DIR}/tap" add Formula/profitctl.rb | |
| git -C "${TMP_DIR}/tap" commit -m "chore: update profitctl formula" | |
| git -C "${TMP_DIR}/tap" push origin HEAD |
Prompt To Fix With AI
This is a comment left during a code review.
Path: scripts/release/publish-homebrew-tap.sh
Line: 27-29
Comment:
**Missing git user identity before commit**
`git commit` requires `user.email` and `user.name` to be configured. In a fresh CI environment (e.g., GitHub Actions runner), these are not set by default, so line 28 will fail with `"Please tell me who you are."` The script's `set -euo pipefail` will surface this as a hard exit without a clear error message.
```suggestion
git -C "${TMP_DIR}/tap" config user.email "github-actions[bot]@users.noreply.github.com"
git -C "${TMP_DIR}/tap" config user.name "github-actions[bot]"
git -C "${TMP_DIR}/tap" add Formula/profitctl.rb
git -C "${TMP_DIR}/tap" commit -m "chore: update profitctl formula"
git -C "${TMP_DIR}/tap" push origin HEAD
```
How can I resolve this? If you propose a fix, please make it concise.
This was referenced Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
env GOCACHE=/tmp/profitctl-go-build GOTMPDIR=/tmp/profitctl-go-tmp go test ./...bash -n scripts/install.shbash -n scripts/release/publish-homebrew-tap.shIntelIP/homebrew-profitctlprofitctl --helpverified after Homebrew installGreptile Summary
This PR adds public-facing CI (GitHub Actions with
verify-goandverify-install-smokejobs), a Homebrew formula for v0.1.2 with a tap-publish script, committed benchmark comparison reports for open-core and hybrid pricing scenarios, and tidies up the design-partner intake flow. The Go engine, covenant, and margin changes add interface-backed implementations with comprehensive test coverage.publish-homebrew-tap.shscript commits to the tap repo without configuringuser.email/user.name, which will fail in any CI environment where git identity is not globally pre-set.Confidence Score: 4/5
Safe to merge after fixing the missing git identity configuration in the tap-publish script.
One P1 defect: the tap-publish script will hard-fail on any CI runner without a global git identity, blocking automated Homebrew releases. All other changes — CI workflow, Homebrew formula, Go engine/covenant/margin code, and tests — are correct and well-structured.
scripts/release/publish-homebrew-tap.sh
Important Files Changed
Sequence Diagram
sequenceDiagram participant Dev as Developer / CI participant GH as GitHub Actions participant Mirror as Local Mirror (RUNNER_TEMP) participant Tap as IntelIP/homebrew-profitctl Dev->>GH: push / PR to main GH->>GH: verify-go (fmt, vet, test) GH->>GH: build-artifacts.sh (v0.0.0-ci) GH->>Mirror: create mirror layout + index.json GH->>GH: install.sh (PROFITCTL_TEST_MIRROR) GH->>GH: profitctl --help + validate smoke Dev->>Dev: run publish-homebrew-tap.sh Dev->>Tap: gh repo clone (depth=1) Dev->>Tap: cp Formula/profitctl.rb Dev->>Tap: git commit + push Tap-->>Dev: tap updatedPrompt To Fix All With AI
Reviews (1): Last reviewed commit: "style: normalize gofmt output for CI" | Re-trigger Greptile