The yaml update #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added logging for empty DataFrames in save_results function. - Introduced process_items function for streamlined item processing. - Improved error handling and logging in Conda and PyPI package utilities. - Updated parsing functions to handle additional file formats and dependencies. - Refactored tests to align with new method signatures and improved functionality.
…update VSCode settings for pytest
There was a problem hiding this comment.
Copilot reviewed 15 out of 17 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- .vscode/settings.json: Language not supported
- pytest.ini: Language not supported
Comments suppressed due to low confidence (2)
src/superbom/utils/packageindexes/pypi/pipdependencies.py:33
- The updated method now processes only a single package instead of iterating over a list. Ensure that this change is intentional and that all corresponding references in the codebase have been updated accordingly.
return package_data
src/superbom/main.py:87
- The 'logger' variable used in the tqdm call is not defined in the scope of process_items. Ensure that a logger instance is properly initialized or passed in to avoid a NameError.
items, desc="Processing items", unit="item", disable=logger.level > logging.INFO
| return None, None | ||
|
|
||
| def retrieve_conda_package_info(self, deps) -> list: | ||
| def retrieve_conda_package_info(self, package) -> dict: |
There was a problem hiding this comment.
The return type annotation is marked as 'dict' but the method actually returns a list. Update the type annotation to reflect that a list is returned.
Suggested change
| def retrieve_conda_package_info(self, package) -> dict: | |
| def retrieve_conda_package_info(self, package) -> list: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.