Potential fix for code scanning alert no. 146: Unbounded write #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| entry->archive=leak_realloc(entry->archive,strlen(archive)+1); | ||
| strcpy(entry->archive,archive); | ||
| strncpy(entry->archive,archive,strlen(archive)+1); |
Check failure
Code scanning / CodeQL
Possibly wrong buffer size in string copy Critical
|
|
||
| entry->member=leak_realloc(entry->member,strlen(member)+1); | ||
| strcpy(entry->member,member); | ||
| strncpy(entry->member,member,strlen(member)+1); |
Check failure
Code scanning / CodeQL
Possibly wrong buffer size in string copy Critical
|
|
||
| entry->output=leak_realloc(entry->output,strlen(output)+1); | ||
| strcpy(entry->output,output); | ||
| strncpy(entry->output,output,strlen(output)+1); |
Check failure
Code scanning / CodeQL
Possibly wrong buffer size in string copy Critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/IntelLabs/async-toolkit/security/code-scanning/146
To fix the issue, calls to
strcpythat copy untrusted data into a buffer, especially those that perform unbounded writes, should be replaced with their bounded counterparts, such asstrncpyormemcpywith an explicit buffer size. Here, beforestrcpy(entry->member, member);the buffer is allocated withleak_realloc(entry->member, strlen(member) + 1), guaranteeing enough space for the string and its null terminator. To future-proof the code and ensure that the buffer is not overrun, usestrncpy(entry->member, member, strlen(member) + 1);. This change should also be applied to the other similar lines (strcpy(entry->archive,archive);on line 123 andstrcpy(entry->output,output);on line 129). However, since the data is allocated with the buffer size exactly matching the string length (plus null terminator), using the bounded version provides additional security by preventing accidental overruns.Edits are confined to the region of the
add_recentfunction inasync-toolkit/atools/lib/archive.c, lines 122-129.Suggested fixes powered by Copilot Autofix. Review carefully before merging.